From: Artem Bityutskiy <dedekind1@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-fsdevel@vger.kernel.org
Subject: [PATCHv6 6/9] sysv: do not mark superblock dirty on remount
Date: Mon, 5 Jul 2010 15:15:04 +0300 [thread overview]
Message-ID: <1278332107-11443-7-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1278332107-11443-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
No need to mark the superblock as dirty in sysv_remount, synchronize
it instead (only if mounting R/O).
I did not find any docs about this file-system, and I have no possibility
to test my changes. Thus, this is untested. I see other issues in sysv,
e.g., why sysv_sync_fs writes only in the FSTYPE_SYSV4 case? However,
it marks its SB bh's dirty for all types, and does not wait for them
ever. With zero docs I'm unable to fix this.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
fs/sysv/inode.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/sysv/inode.c b/fs/sysv/inode.c
index d4a5380..661bab5 100644
--- a/fs/sysv/inode.c
+++ b/fs/sysv/inode.c
@@ -71,8 +71,8 @@ static int sysv_remount(struct super_block *sb, int *flags, char *data)
lock_super(sb);
if (sbi->s_forced_ro)
*flags |= MS_RDONLY;
- if (!(*flags & MS_RDONLY))
- sb->s_dirt = 1;
+ if (*flags & MS_RDONLY)
+ sysv_write_super(sb);
unlock_super(sb);
return 0;
}
--
1.7.0.1
next prev parent reply other threads:[~2010-07-05 12:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 12:14 [PATCHv6 0/9] kill unnecessary SB sync wake-ups + cleanups Artem Bityutskiy
2010-07-05 12:14 ` [PATCHv6 1/9] AFFS: clean up dirty flag usage Artem Bityutskiy
2010-07-05 12:15 ` [PATCHv6 2/9] AFFS: wait for sb synchronization when needed Artem Bityutskiy
2010-07-05 12:15 ` [PATCHv6 3/9] BFS: clean up the superblock usage Artem Bityutskiy
2010-07-05 12:15 ` [PATCHv6 4/9] btrfs: remove junk sb_dirt change Artem Bityutskiy
2010-07-05 12:15 ` [PATCHv6 5/9] sysv: do not mark superblock dirty on mount Artem Bityutskiy
2010-07-05 12:15 ` Artem Bityutskiy [this message]
2010-07-05 12:15 ` [PATCHv6 7/9] FS: convert all file-systems and VFS to new SB accessors Artem Bityutskiy
2010-07-05 12:15 ` [PATCHv6 8/9] VFS: rename s_dirt to s_dirty Artem Bityutskiy
2010-07-05 12:15 ` [PATCHv6 9/9] writeback: lessen sync_supers wakeup count Artem Bityutskiy
2010-07-22 7:54 ` [PATCHv6 0/9] kill unnecessary SB sync wake-ups + cleanups Artem Bityutskiy
2010-07-22 8:50 ` Al Viro
2010-07-25 9:32 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278332107-11443-7-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).