From: Artem Bityutskiy <dedekind1@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH, RFC] simplify writeback thread creation
Date: Thu, 08 Jul 2010 16:22:27 +0300 [thread overview]
Message-ID: <1278595347.20321.27.camel@localhost> (raw)
In-Reply-To: <20100707225242.GA28802@lst.de>
On Thu, 2010-07-08 at 00:52 +0200, Christoph Hellwig wrote:
> @@ -503,18 +359,10 @@ int bdi_register(struct backing_dev_info
> * and add other bdi's to the list. They will get a thread
> created
> * on-demand when they need it.
> */
Just noticed that this comment should be killed as well.
> - if (bdi_cap_flush_forker(bdi)) {
> - struct bdi_writeback *wb = &bdi->wb;
> -
> - wb->task = kthread_run(bdi_forker_task, wb, "bdi-%s",
> - dev_name(dev));
> - if (IS_ERR(wb->task)) {
> - wb->task = NULL;
> - ret = -ENOMEM;
> -
> - bdi_remove_from_list(bdi);
> + if (bdi_cap_writeback_dirty(bdi)) {
> + ret = bdi_writeback_enable(bdi, dev);
> + if (ret)
> goto exit;
>
>
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-07-08 13:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 22:52 [PATCH, RFC] simplify writeback thread creation Christoph Hellwig
2010-07-08 7:08 ` Artem Bityutskiy
2010-07-08 12:20 ` Jens Axboe
2010-07-08 14:21 ` Artem Bityutskiy
2010-07-08 14:59 ` Jens Axboe
2010-07-08 15:23 ` Artem Bityutskiy
2010-07-08 17:23 ` Jens Axboe
2010-07-08 18:43 ` Artem Bityutskiy
2010-07-08 18:48 ` Christoph Hellwig
2010-07-09 7:52 ` Artem Bityutskiy
2010-07-09 8:16 ` Jens Axboe
2010-07-09 11:06 ` Theodore Tso
2010-07-09 14:51 ` Christoph Hellwig
2010-07-09 15:49 ` Artem Bityutskiy
2010-07-08 13:22 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278595347.20321.27.camel@localhost \
--to=dedekind1@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).