From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH, RFC] simplify writeback thread creation Date: Thu, 08 Jul 2010 16:22:27 +0300 Message-ID: <1278595347.20321.27.camel@localhost> References: <20100707225242.GA28802@lst.de> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: axboe@kernel.dk, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from smtp.nokia.com ([192.100.105.134]:39137 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751173Ab0GHN1R (ORCPT ); Thu, 8 Jul 2010 09:27:17 -0400 In-Reply-To: <20100707225242.GA28802@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 2010-07-08 at 00:52 +0200, Christoph Hellwig wrote: > @@ -503,18 +359,10 @@ int bdi_register(struct backing_dev_info > * and add other bdi's to the list. They will get a thread > created > * on-demand when they need it. > */ Just noticed that this comment should be killed as well. > - if (bdi_cap_flush_forker(bdi)) { > - struct bdi_writeback *wb =3D &bdi->wb; > - > - wb->task =3D kthread_run(bdi_forker_task, wb, "bdi-%s= ", > - dev_name(dev)); > - if (IS_ERR(wb->task)) { > - wb->task =3D NULL; > - ret =3D -ENOMEM; > - > - bdi_remove_from_list(bdi); > + if (bdi_cap_writeback_dirty(bdi)) { > + ret =3D bdi_writeback_enable(bdi, dev); > + if (ret) > goto exit; >=20 >=20 --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html