From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH 4/4] writeback: harmonize writeback threads and tasks - 3 Date: Tue, 13 Jul 2010 17:30:28 +0300 Message-ID: <1279031428.31639.93.camel@localhost> References: <1278920994-2402-1-git-send-email-dedekind1@gmail.com> <1278920994-2402-5-git-send-email-dedekind1@gmail.com> <20100712153316.GA26429@infradead.org> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jens Axboe , linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from smtp.nokia.com ([192.100.122.233]:17248 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756543Ab0GMOfq (ORCPT ); Tue, 13 Jul 2010 10:35:46 -0400 In-Reply-To: <20100712153316.GA26429@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 2010-07-12 at 11:33 -0400, Christoph Hellwig wrote: > On Mon, Jul 12, 2010 at 10:49:54AM +0300, Artem Bityutskiy wrote: > > From: Artem Bityutskiy > >=20 > > The write-back code mixes words "thread" and "task" for the > > same things - this is not a problem, but this is still an > > inconsistency which makes it a bit difficult to read the code. > > It is better to use term "thread" consistently everywhere. > >=20 > > This patch amends commentaries and makes them refer the forker thre= ad and the > > write-back threads as "threads", not "tasks". >=20 > A convention I tend to use and I've seen in various places is to alwa= ys > use _task for the storage of the task_struct pointer, and thread > everywhere else. This especially helps with having foo_thread for th= e > actual thread and foo_task for a global variable keeping the > task_struct pointer. OK, thanks for feed-back, then I'll drop the patch which renames bdi->wb.task to bdi->wb.thread. Namely, this one: [PATCH 3/4] writeback: harmonize writeback threads and tasks - 2 --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html