linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bob Copeland <me@bobcopeland.com>
To: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Davidlohr Bueso <dave.bueso@gmail.com>,
	Davidlohr Bueso <dave@gnu.org>, Bob Copeland <me@bobcopeland.com>
Subject: [PATCH 1/4] omfs: fix memory leak
Date: Wed, 14 Jul 2010 23:26:18 -0400	[thread overview]
Message-ID: <1279164381-9247-2-git-send-email-me@bobcopeland.com> (raw)
In-Reply-To: <1279164381-9247-1-git-send-email-me@bobcopeland.com>

From: Davidlohr Bueso <dave.bueso@gmail.com>

In the error path of omfs_fill_super(), the FS super block info
(sbi) is not being freed.  Correct this.

Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
 fs/omfs/inode.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c
index 089839a..b5d6380 100644
--- a/fs/omfs/inode.c
+++ b/fs/omfs/inode.c
@@ -529,6 +529,8 @@ out_brelse_bh2:
 out_brelse_bh:
 	brelse(bh);
 end:
+	if (ret)
+		kfree(sbi);
 	return ret;
 }
 
-- 
1.5.6.5

  reply	other threads:[~2010-07-15  3:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-15  3:26 [PATCH 0/4] OMFS bug fixes Bob Copeland
2010-07-15  3:26 ` Bob Copeland [this message]
2010-07-15  3:26 ` [PATCH 2/4] omfs: check bounds on block numbers before passing to sb_bread Bob Copeland
2010-07-15  3:26 ` [PATCH 3/4] omfs: refuse to mount if bitmap pointer is obviously wrong Bob Copeland
2010-07-15  3:26 ` [PATCH 4/4] omfs: sanity check cluster size Bob Copeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279164381-9247-2-git-send-email-me@bobcopeland.com \
    --to=me@bobcopeland.com \
    --cc=dave.bueso@gmail.com \
    --cc=dave@gnu.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).