From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: [RFC][PATCH 02/16] writeback: remove redundant list initialization Date: Fri, 16 Jul 2010 15:44:58 +0300 Message-ID: <1279284312-2411-3-git-send-email-dedekind1@gmail.com> References: <1279284312-2411-1-git-send-email-dedekind1@gmail.com> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Jens Axboe Return-path: In-Reply-To: <1279284312-2411-1-git-send-email-dedekind1@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org From: Artem Bityutskiy We do not have to call 'INIT_LIST_HEAD()' for list elements ('bdi->bdi_list') before inserting them to the 'bdi_pending_list', because 'list_add_tail' will initialize the element anyway. Thus, kill the redundant initialization. Signed-off-by: Artem Bityutskiy --- mm/backing-dev.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index ff5669a..0fad60d 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -416,7 +416,6 @@ static void bdi_add_to_pending(struct rcu_head *head) struct backing_dev_info *bdi; bdi = container_of(head, struct backing_dev_info, rcu_head); - INIT_LIST_HEAD(&bdi->bdi_list); spin_lock(&bdi_lock); list_add_tail(&bdi->bdi_list, &bdi_pending_list); -- 1.7.1.1