From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [RFC][PATCH 01/16] writeback: do not self-wakeup Date: Sun, 18 Jul 2010 12:43:09 +0300 Message-ID: <1279446189.16247.49.camel@localhost.localdomain> References: <1279284312-2411-1-git-send-email-dedekind1@gmail.com> <1279284312-2411-2-git-send-email-dedekind1@gmail.com> <20100718064435.GA23811@infradead.org> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:43738 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753700Ab0GRJnO (ORCPT ); Sun, 18 Jul 2010 05:43:14 -0400 In-Reply-To: <20100718064435.GA23811@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, 2010-07-18 at 02:44 -0400, Christoph Hellwig wrote: > On Fri, Jul 16, 2010 at 03:44:57PM +0300, Artem Bityutskiy wrote: > > From: Artem Bityutskiy > >=20 > > The bdi forker thread wakes up itself via 'bdi_add_to_pending()'. > > And the thread is the only user of 'bdi_add_to_pending()'. Thus, > > we can safely zap the unneeded 'wake_up_process()' call. >=20 > At least right now it's called using call_rcu, which offloads the fun= ction > to a RCU thread of some sorts. Christoph, thanks for your review. I'll amend my series and re-send. An= d I also have to think about some of your suggestions. I did not CC you to spam your mailbox less, since I'm sure you would no= t miss the series in the fsdevel ML. But if you prefer being CCed, let me know. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html