From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [RFC][PATCH 12/16] writeback: add to bdi_list in the forker thread Date: Tue, 20 Jul 2010 14:32:12 +0300 Message-ID: <1279625532.16462.117.camel@localhost> References: <1279284312-2411-1-git-send-email-dedekind1@gmail.com> <1279284312-2411-13-git-send-email-dedekind1@gmail.com> <20100718065851.GJ23811@infradead.org> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Christoph Hellwig Return-path: In-Reply-To: <20100718065851.GJ23811@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sun, 2010-07-18 at 02:58 -0400, Christoph Hellwig wrote: > What about never removing a bdi from bdi_list? If we have the > correct checks for dirty_io and the task there's no need to > ever remove a life bdi from the list. Just add it in bdi_register > and remove it in bdi_unregister. But I think it will be less error-prone and nicer to still have this patch, then move the killing logic from bdi threads to the forker task, and then, as a separate patch on top of that, get rid of this removing bdi from bdi_list part. I mean, this way the patch series will be more logical and finer grained and easier to review. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9)