From: Artem Bityutskiy <dedekind1@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
Dave Chinner <dchinner@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCHv2 11/11] writeback: prevent unnecessary bdi threads wakeups
Date: Thu, 22 Jul 2010 12:24:13 +0300 [thread overview]
Message-ID: <1279790653.3044.35.camel@localhost> (raw)
In-Reply-To: <20100722090023.GA7692@infradead.org>
On Thu, 2010-07-22 at 05:00 -0400, Christoph Hellwig wrote:
> if (wakeup_bdi) {
> spin_lock(&bdi->wb_lock);
> if (bdi->wb.task) {
> trace_writeback_wake_thread(bdi);
> wake_up_process(bdi->wb.task);
> } else {
> trace_writeback_wake_forker_thread(bdi);
> wake_up_process(default_backing_dev_info.wb.task);
> }
> spin_unlock(&bdi->wb_lock);
> }
Side note: I've noticed you've made the optimistic "if" condition first,
which is better, and I'll also amend this in v3.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-07-22 9:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 9:31 [PATCHv2 00/16] kill unnecessary bdi wakeups + cleanups Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 01/11] writeback: harmonize writeback threads naming Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 02/11] writeback: fix possible race when creating bdi threads Artem Bityutskiy
2010-07-21 11:57 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 03/11] writeback: do not lose wake-ups in the forker thread - 1 Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 04/11] writeback: do not lose wake-ups in the forker thread - 2 Artem Bityutskiy
2010-07-21 11:57 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 05/11] writeback: do not lose wake-ups in bdi threads Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 06/11] writeback: simplify bdi code a little Artem Bityutskiy
2010-07-21 12:01 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 07/11] writeback: do not remove bdi from bdi_list Artem Bityutskiy
2010-07-21 12:02 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 08/11] writeback: move last_active to bdi Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 09/11] writeback: restructure bdi forker loop a little Artem Bityutskiy
2010-07-21 12:02 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 10/11] writeback: move bdi threads exiting logic to the forker thread Artem Bityutskiy
2010-07-21 12:04 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 11/11] writeback: prevent unnecessary bdi threads wakeups Artem Bityutskiy
2010-07-21 11:45 ` Artem Bityutskiy
2010-07-22 0:41 ` Dave Chinner
2010-07-22 6:50 ` Artem Bityutskiy
2010-07-22 9:00 ` Christoph Hellwig
2010-07-22 9:24 ` Artem Bityutskiy [this message]
2010-07-22 13:27 ` Artem Bityutskiy
2010-07-21 12:12 ` Christoph Hellwig
2010-07-22 3:19 ` Nick Piggin
2010-07-22 6:48 ` Artem Bityutskiy
2010-07-22 7:22 ` Tero.Kristo
2010-07-22 8:07 ` Nick Piggin
2010-07-22 8:05 ` Nick Piggin
2010-07-22 8:02 ` Artem Bityutskiy
2010-07-22 8:59 ` Nick Piggin
2010-07-22 9:50 ` Artem Bityutskiy
2010-07-23 15:03 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279790653.3044.35.camel@localhost \
--to=dedekind1@gmail.com \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).