linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCHv3 14/14] writeback: add new tracepoints
Date: Thu, 22 Jul 2010 16:56:28 +0300	[thread overview]
Message-ID: <1279806988-14100-15-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1279806988-14100-1-git-send-email-dedekind1@gmail.com>

From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Add 2 new trace points to the periodic write-back wake up case, just like we do
in the 'bdi_queue_work()' function. Namely, introduce:

1. trace_writeback_wakeup(bdi)
2. trace_writeback_wakeup_nothread(bdi)

The first event is triggered every time we wake up a bdi thread to start
periodic background write-out. The second event is triggered only when the bdi
thread does not exist and should be created by the forker thread.

This patch was suggested by Dave Chinner <david@fromorbit.com>

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 include/trace/events/writeback.h |    2 ++
 mm/backing-dev.c                 |    3 +++
 2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
index 84ab72d..eb07d48 100644
--- a/include/trace/events/writeback.h
+++ b/include/trace/events/writeback.h
@@ -81,6 +81,8 @@ DEFINE_EVENT(writeback_class, name, \
 	TP_ARGS(bdi))
 
 DEFINE_WRITEBACK_EVENT(writeback_nowork);
+DEFINE_WRITEBACK_EVENT(writeback_wakeup);
+DEFINE_WRITEBACK_EVENT(writeback_wakeup_nothread);
 DEFINE_WRITEBACK_EVENT(writeback_bdi_register);
 DEFINE_WRITEBACK_EVENT(writeback_bdi_unregister);
 DEFINE_WRITEBACK_EVENT(writeback_thread_start);
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 90e56ab..9143f93 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -308,6 +308,8 @@ static void wakeup_timer_fn(unsigned long data)
 {
 	struct backing_dev_info *bdi = (struct backing_dev_info *)data;
 
+	trace_writeback_wakeup(bdi);
+
 	spin_lock(&bdi->wb_lock);
 	if (bdi->wb.task) {
 		wake_up_process(bdi->wb.task);
@@ -317,6 +319,7 @@ static void wakeup_timer_fn(unsigned long data)
 		 * In this case we have to wake-up the forker thread which
 		 * should create and run the bdi thread.
 		 */
+		trace_writeback_wakeup_nothread(bdi);
 		wake_up_process(default_backing_dev_info.wb.task);
 	}
 	spin_unlock(&bdi->wb_lock);
-- 
1.7.1.1


      parent reply	other threads:[~2010-07-22 13:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22 13:56 [PATCHv3 00/14] kill unnecessary bdi wakeups + cleanups Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 01/14] writeback: harmonize writeback threads naming Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 02/14] writeback: fix possible race when creating bdi threads Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 03/14] writeback: do not lose wake-ups in the forker thread - 1 Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 04/14] writeback: do not lose wake-ups in the forker thread - 2 Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 05/14] writeback: do not lose wake-ups in bdi threads Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 06/14] writeback: simplify bdi code a little Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 07/14] writeback: do not remove bdi from bdi_list Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 08/14] writeback: move last_active to bdi Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 09/14] writeback: restructure bdi forker loop a little Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 10/14] writeback: move bdi threads exiting logic to the forker thread Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 11/14] writeback: prevent unnecessary bdi threads wakeups Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 12/14] writeback: optimize periodic bdi thread wakeups Artem Bityutskiy
2010-07-22 13:56 ` [PATCHv3 13/14] writeback: remove unnecessary init_timer call Artem Bityutskiy
2010-07-22 13:56 ` Artem Bityutskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279806988-14100-15-git-send-email-dedekind1@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).