From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCHv4 10/14] writeback: move bdi threads exiting logic to the forker thread Date: Sat, 24 Jul 2010 08:55:06 +0300 Message-ID: <1279950907.4655.0.camel@localhost> References: <1279897554-1526-1-git-send-email-dedekind1@gmail.com> <1279897554-1526-11-git-send-email-dedekind1@gmail.com> <20100723162311.GA29633@infradead.org> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from smtp.nokia.com ([192.100.105.134]:35251 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508Ab0GXGCY (ORCPT ); Sat, 24 Jul 2010 02:02:24 -0400 In-Reply-To: <20100723162311.GA29633@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 2010-07-23 at 12:23 -0400, Christoph Hellwig wrote: > Looks good, >=20 > Reviewed-by: Christoph Hellwig >=20 > Maybe bdi_forker_thread can be cleaned up a bit more by introducing a >=20 > enum { > NO_ACTION, > START_THREAD, > KILL_THREAD, > } action; >=20 > and then do a switch based on it later? Just did this. May be it became a bit nicer, not sure. Matter of taste. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html