From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCHv5 13/15] writeback: remove unnecessary init_timer call
Date: Sun, 25 Jul 2010 11:29:39 +0300 [thread overview]
Message-ID: <1280046581-23623-14-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1280046581-23623-1-git-send-email-dedekind1@gmail.com>
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
The 'setup_timer()' function also calls 'init_timer()', so the extra
'init_timer()' call is not needed. Indeed, 'setup_timer()' is basically
'init_timer()' plus callback function and data pointers initialization.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
mm/backing-dev.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index c2def00..7cef95e 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -236,7 +236,6 @@ static int __init default_bdi_init(void)
sync_supers_tsk = kthread_run(bdi_sync_supers, NULL, "sync_supers");
BUG_ON(IS_ERR(sync_supers_tsk));
- init_timer(&sync_supers_timer);
setup_timer(&sync_supers_timer, sync_supers_timer_fn, 0);
bdi_arm_supers_timer();
--
1.7.1.1
next prev parent reply other threads:[~2010-07-25 8:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-25 8:29 [PATCHv5 00/15] kill unnecessary bdi wakeups + cleanups Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 01/15] writeback: harmonize writeback threads naming Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 02/15] writeback: fix possible race when creating bdi threads Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 03/15] writeback: do not lose wake-ups in the forker thread - 1 Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 04/15] writeback: do not lose wake-ups in the forker thread - 2 Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 05/15] writeback: do not lose wake-ups in bdi threads Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 06/15] writeback: simplify bdi code a little Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 07/15] writeback: do not remove bdi from bdi_list Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 08/15] writeback: move last_active to bdi Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 09/15] writeback: restructure bdi forker loop a little Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 10/15] writeback: move bdi threads exiting logic to the forker thread Artem Bityutskiy
2010-07-25 9:26 ` [PATCHv5-1 " Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 11/15] writeback: prevent unnecessary bdi threads wakeups Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 12/15] writeback: optimize periodic bdi thread wakeups Artem Bityutskiy
2010-07-25 10:41 ` Artem Bityutskiy
2010-07-25 8:29 ` Artem Bityutskiy [this message]
2010-07-25 8:29 ` [PATCHv5 14/15] writeback: add new tracepoints Artem Bityutskiy
2010-07-25 8:29 ` [PATCHv5 15/15] writeback: cleanup bdi_register Artem Bityutskiy
2010-07-25 9:01 ` [PATCHv5 00/15] kill unnecessary bdi wakeups + cleanups Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280046581-23623-14-git-send-email-dedekind1@gmail.com \
--to=dedekind1@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).