linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCHv6 04/15] writeback: do not lose wake-ups in the forker thread - 2
Date: Sun, 25 Jul 2010 14:29:14 +0300	[thread overview]
Message-ID: <1280057365-10297-5-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1280057365-10297-1-git-send-email-dedekind1@gmail.com>

From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

Currently, if someone submits jobs for the default bdi, we can lose wake-up
events. E.g., this can happen if 'bdi_queue_work()' is called when
'bdi_forker_thread()' is executing code after 'wb_do_writeback(me, 0)', but
before 'set_current_state(TASK_INTERRUPTIBLE)'.

This situation is unlikely, and the result is not very severe - we'll just
delay the execution of the work, but this is still not very nice.

This patch fixes the issue by checking whether the default bdi has works before
the forker thread goes sleep.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 mm/backing-dev.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index b1dc2d4..72e6eb9 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -358,6 +358,10 @@ static int bdi_forker_thread(void *ptr)
 			bdi_add_default_flusher_thread(bdi);
 		}
 
+		/* Keep working if default bdi still has things to do */
+		if (!list_empty(&me->bdi->work_list))
+			__set_current_state(TASK_RUNNING);
+
 		if (list_empty(&bdi_pending_list)) {
 			unsigned long wait;
 
-- 
1.7.1.1

  parent reply	other threads:[~2010-07-25 11:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-25 11:29 [PATCHv6 00/15] kill unnecessary bdi wakeups + cleanups Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 01/15] writeback: harmonize writeback threads naming Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 02/15] writeback: fix possible race when creating bdi threads Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 03/15] writeback: do not lose wake-ups in the forker thread - 1 Artem Bityutskiy
2010-07-25 11:29 ` Artem Bityutskiy [this message]
2010-07-25 11:29 ` [PATCHv6 05/15] writeback: do not lose wake-ups in bdi threads Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 06/15] writeback: simplify bdi code a little Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 07/15] writeback: do not remove bdi from bdi_list Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 08/15] writeback: move last_active to bdi Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 09/15] writeback: restructure bdi forker loop a little Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 10/15] writeback: move bdi threads exiting logic to the forker thread Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 11/15] writeback: prevent unnecessary bdi threads wakeups Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 12/15] writeback: optimize periodic bdi thread wakeups Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 13/15] writeback: remove unnecessary init_timer call Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 14/15] writeback: add new tracepoints Artem Bityutskiy
2010-07-25 11:29 ` [PATCHv6 15/15] writeback: cleanup bdi_register Artem Bityutskiy
2010-08-03  4:44 ` [PATCHv6 00/15] kill unnecessary bdi wakeups + cleanups Artem Bityutskiy
2010-08-03 12:27 ` Jens Axboe
2010-08-03 12:37   ` Artem Bityutskiy
2010-08-03 12:47     ` Jens Axboe
2010-08-04 11:34       ` Jens Axboe
2010-08-05  9:35         ` Artem Bityutskiy
2010-08-03 14:11   ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280057365-10297-5-git-send-email-dedekind1@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).