From: Dave Chinner <david@fromorbit.com>
To: linux-fsdevel@vger.kernel.org
Cc: xfs@oss.sgi.com
Subject: [PATCH 3/3] dio: add a mempool for the unaligned block structures
Date: Tue, 3 Aug 2010 17:23:24 +1000 [thread overview]
Message-ID: <1280820204-1418-4-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1280820204-1418-1-git-send-email-david@fromorbit.com>
From: Dave Chinner <dchinner@redhat.com>
We need the zero block tracking structure allocation to succeed.
Silently failing and potentially allowing data corruption is not an
option. Add a mempool to ensure this allocation will always succeed.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/direct-io.c | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/fs/direct-io.c b/fs/direct-io.c
index 368abec..dfc5d9a 100644
--- a/fs/direct-io.c
+++ b/fs/direct-io.c
@@ -161,12 +161,22 @@ struct dio_zero_block_head {
static struct dio_zero_block_head dio_zero_blocks[DIO_ZERO_BLOCK_NR];
#define to_dio_zero_head(zb) (&dio_zero_blocks[zb % DIO_ZERO_BLOCK_NR])
+/* a small mempool just to guarantee progress. */
+#define DIO_ZERO_BLOCK_ENTRIES 2
+static mempool_t *dio_zero_block_pool;
+
static int __init
dio_init_zero_block(void)
{
int i;
+ dio_zero_block_pool = mempool_create_kmalloc_pool(
+ DIO_ZERO_BLOCK_ENTRIES,
+ sizeof(struct dio_zero_block));
+ if (!dio_zero_block_pool)
+ panic("dio: can't create zero block pool");
+
for (i = 0; i < DIO_ZERO_BLOCK_NR; i++) {
spin_lock_init(&dio_zero_blocks[i].lock);
INIT_LIST_HEAD(&dio_zero_blocks[i].list);
@@ -184,9 +194,7 @@ dio_start_zero_block(struct dio *dio, sector_t zero_block)
struct dio_zero_block_head *zbh = to_dio_zero_head(zero_block);
struct dio_zero_block *zb;
- zb = kmalloc(sizeof(*zb), GFP_NOIO);
- if (!zb)
- return;
+ zb = mempool_alloc(dio_zero_block_pool, GFP_NOIO);
INIT_LIST_HEAD(&zb->dio_list);
init_waitqueue_head(&zb->wq);
zb->zero_block = zero_block;
--
1.7.1
next prev parent reply other threads:[~2010-08-03 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 7:23 [PATCH 0/3] dio: serialise unaligned direct IO V3 Dave Chinner
2010-08-03 7:23 ` [PATCH 1/3] dio: track and serialise unaligned direct IO Dave Chinner
2010-08-03 7:23 ` [PATCH 2/3] dio: scale unaligned IO tracking via multiple lists Dave Chinner
2010-08-03 7:23 ` Dave Chinner [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-08 7:40 [REPOST, PATCH 0/3] dio: serialise unaligned direct IO Dave Chinner
2010-11-08 7:40 ` [PATCH 3/3] dio: add a mempool for the unaligned block structures Dave Chinner
2010-11-08 15:40 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280820204-1418-4-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).