From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCHv6 00/15] kill unnecessary bdi wakeups + cleanups Date: Tue, 03 Aug 2010 15:37:16 +0300 Message-ID: <1280839036.15689.8.camel@localhost> References: <1280057365-10297-1-git-send-email-dedekind1@gmail.com> <4C580B1C.3020409@kernel.dk> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Jens Axboe Return-path: In-Reply-To: <4C580B1C.3020409@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2010-08-03 at 14:27 +0200, Jens Axboe wrote: > On 2010-07-25 13:29, Artem Bityutskiy wrote: > > Hi, > >=20 > > here is v6 of the patch series which clean-ups bdi threads and subs= tantially > > lessens amount of unnecessary kernel wake-ups, which is very import= ant on > > battery-powered devices. > >=20 > > This patch-set is also available at: > > git://git.infradead.org/users/dedekind/misc-2.6.git flushers_v6 >=20 > Thanks Artem, for sticking around long enough to get this into > shape. I have finally merged it. Thanks, but > > 1. Use 'spin_lock_bh' for the 'bdi->wb_lock' (changed patch N12) >=20 > I'd rather not, question is how to avoid it. Either just wakeup the > default thread, or punt the lock-and-check bdi->wb.task to a thread. you merged this change, do you want me to send a separate patch which undo the 'spin_lock_bh' change? I'll think about how to avoid this and come back. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9)