From: Steven Whitehouse <swhiteho@redhat.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH -next] quota: fix QUOTACTL kconfig for gfs2
Date: Thu, 12 Aug 2010 16:57:20 +0100 [thread overview]
Message-ID: <1281628640.2434.41.camel@localhost> (raw)
In-Reply-To: <4C6415C1.9000905@oracle.com>
Hi,
On Thu, 2010-08-12 at 08:39 -0700, Randy Dunlap wrote:
> On 08/11/10 19:46, Jan Kara wrote:
> > On Wed 11-08-10 16:24:35, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> warning: (GFS2_FS && BLOCK && EXPERIMENTAL && (64BIT || LBDAF)) selects QUOTACTL which has unmet direct dependencies (XFS_QUOTA || QUOTA)
> >>
> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >> Cc: Steven Whitehouse <swhiteho@redhat.com>
> >> Cc: cluster-devel@redhat.com
> >> ---
> >> fs/quota/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> However, the "depends on" line here seems like overkill to me.
> > OK, so do you mean that making QUOTACTL default to 'n', removing the
> > depends on line and letting QUOTA, XFS_QUOTA, and GFS2_QUOTA select
> > QUOTACTL would be better?
>
I'm not sure I follow. What is GFS2_QUOTA in this case? GFS2 used to
select QUOTA as well, but Christoph removed that. Shouldn't the user
interface part of quota be separate from the core implementation?
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e9edb1d8a345119c9baafa1b240eb1ec06a44662
Steve.
next prev parent reply other threads:[~2010-08-12 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 23:24 [PATCH -next] quota: fix QUOTACTL kconfig for gfs2 Randy Dunlap
2010-08-12 2:46 ` Jan Kara
2010-08-12 15:39 ` Randy Dunlap
2010-08-12 15:57 ` Steven Whitehouse [this message]
2010-08-12 16:03 ` Randy Dunlap
2010-08-12 16:14 ` Christoph Hellwig
2010-08-12 16:34 ` Steven Whitehouse
2010-08-12 16:41 ` Randy Dunlap
2010-08-17 10:22 ` Jan Kara
2010-08-17 15:03 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281628640.2434.41.camel@localhost \
--to=swhiteho@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).