From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Venkateswararao Jujjuri (JV)" Subject: [PATCH-V2] [fs/9p] Fix NULL point deref in v9fs_dir_release Date: Sun, 22 Aug 2010 19:08:32 -0700 Message-ID: <1282529312-11861-1-git-send-email-jvrao@linux.vnet.ibm.com> Cc: linux-fsdevel@vger.kernel.org, "Venkateswararao Jujjuri (JV)" To: v9fs-developer@lists.sourceforge.net Return-path: Received: from e39.co.us.ibm.com ([32.97.110.160]:52079 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508Ab0HWB7p (ORCPT ); Sun, 22 Aug 2010 21:59:45 -0400 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by e39.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id o7N1ndNU020428 for ; Sun, 22 Aug 2010 19:49:39 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o7N1xiar217340 for ; Sun, 22 Aug 2010 19:59:44 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o7N1xhTi030053 for ; Sun, 22 Aug 2010 19:59:44 -0600 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: changes from v1: Now checking fid instead of filp. There are situations in VFS where we endup calling v9fs_dir_release() before even we instantiate the fid in filp. Hence the check. Signed-off-by: Venkateswararao Jujjuri --- fs/9p/vfs_dir.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/9p/vfs_dir.c b/fs/9p/vfs_dir.c index 16c8a2a..5b01842 100644 --- a/fs/9p/vfs_dir.c +++ b/fs/9p/vfs_dir.c @@ -291,6 +291,8 @@ int v9fs_dir_release(struct inode *inode, struct file *filp) struct p9_fid *fid; fid = filp->private_data; + if (!fid) + return 0; P9_DPRINTK(P9_DEBUG_VFS, "inode: %p filp: %p fid: %d\n", inode, filp, fid->fid); filemap_write_and_wait(inode->i_mapping); -- 1.6.5.2