linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Matt Helsley <matthltc@us.ibm.com>,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
	viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
	Michael Kerrisk <michael.kerrisk@gmail.com>
Subject: Re: [GIT PULL] notification tree - try 37!
Date: Mon, 23 Aug 2010 12:46:13 -0400	[thread overview]
Message-ID: <1282581973.2681.22.camel@localhost.localdomain> (raw)
In-Reply-To: <201008201438.16637.agruen@suse.de>

On Fri, 2010-08-20 at 14:38 +0200, Andreas Gruenbacher wrote:
> On Friday 20 August 2010 05:50:36 Eric Paris wrote:
> > We must be doing something different...  What kernel?  what kconfig?
> > What exact FS setup?  What exact steps are you taking?  What programs
> > are you using to test east side?
> 
> I'm runnning 2.6.36-rc1, with CONFIG_FANOTIFY and 
> CONFIG_FANOTIFY_ACCESS_PERMISSIONS on apparently.  I am watching the same 
> directory with inotify and fanotify at the same time, that is, with both an 
> inotify and an fanotify listener running in two separate processes.  The 
> inotify listener is code I cannot send so easily, but I've shown the resulting 
> strace.  The fanotify listener is the one from [1].
> 
> 	[1] http://git.kernel.org/?p=linux/kernel/git/agruen/fanotify-example.git
> 
> Together with the traces I've provided this should give you way enough clues 
> to be able to look up in the code why listening for fanotify events apparently 
> causes a concurrent inotify listener to return an inotify event with struct 
> inotify_event->mask == 0 for each fanotify perm event.

Spent a bit of the weekend trying to figure out what you were doing and
couldn't reproduce it or find it in the code because I had already fixed
it (albeit for slightly different reasons).  The patch in question was:

http://marc.info/?l=linux-kernel&m=128214903125780&w=2

the vfsmount_test_mask was always initialized but since no vfsmount
marks were found it was never cleared.  This left the code thinking that
the given (inode) mark was interested in the event.  I think you could
reproduce it differently

inotifywait -m -e open /mnt/tmp
inotifywait -m -e close /mnt/tmp

and you would get both event types for both watches.

-Eric

  reply	other threads:[~2010-08-23 16:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1281110319.17812.21.camel@dhcp231-200.rdu.redhat.com>
     [not found] ` <201008191444.08966.agruen@suse.de>
     [not found]   ` <1282230012.21419.1566.camel@acb20005.ipt.aol.com>
2010-08-19 23:41     ` [GIT PULL] notification tree: directory events Andreas Gruenbacher
2010-08-20  3:38       ` Eric Paris
2010-08-20  5:19         ` Andreas Dilger
2010-08-20  9:21           ` Christoph Hellwig
2010-08-20 15:29             ` Andreas Gruenbacher
2010-08-20 20:39               ` Andreas Dilger
2010-08-20  9:09         ` Tvrtko Ursulin
2010-08-20 11:07         ` Andreas Gruenbacher
2010-08-20 11:25         ` Andreas Gruenbacher
2010-08-20 12:16         ` Andreas Gruenbacher
     [not found] ` <1282016387.21419.113.camel@acb20005.ipt.aol.com>
     [not found]   ` <201008171009.51737.agruen@suse.de>
2010-08-20  0:00     ` [GIT PULL] notification tree - try 37! Andreas Gruenbacher
     [not found] ` <201008192307.32526.agruen@suse.de>
     [not found]   ` <1282276236.21419.2101.camel@acb20005.ipt.aol.com>
2010-08-20 12:38     ` Andreas Gruenbacher
2010-08-23 16:46       ` Eric Paris [this message]
2010-08-23 22:38         ` Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282581973.2681.22.camel@localhost.localdomain \
    --to=eparis@redhat.com \
    --cc=agruen@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthltc@us.ibm.com \
    --cc=michael.kerrisk@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).