linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: "Ozan Çağlayan" <ozan@pardus.org.tr>
Cc: Steve Grubb <sgrubb@redhat.com>, James Morris <jmorris@namei.org>,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	Casey Schaufler <casey@schaufler-ca.com>,
	David Safford <safford@watson.ibm.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	Mimi Zohar <zohar@us.ibm.com>
Subject: Re: [PATCH] security: move LSM xattrnames to xattr.h
Date: Tue, 12 Oct 2010 09:06:09 -0400	[thread overview]
Message-ID: <1286888769.2670.5.camel@localhost.localdomain> (raw)
In-Reply-To: <201010121414.14486.ozan@pardus.org.tr>

On Tue, 2010-10-12 at 14:14 +0300, Ozan Çağlayan wrote:
> Cuma 02 Temmuz 2010 günü (saat 03:16:01) James Morris şunları yazmıştı:
> > On Thu, 1 Jul 2010, Mimi Zohar wrote:
> > > Make the security extended attributes names global. Updated to move
> > > the remaining Smack xattrs.
> > > 
> > > Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
> > > Acked-by: Serge Hallyn <serue@us.ibm.com>
> > 
> 
> This drops 
> 
> #define XATTR_CAPS_SUFFIX "capability"
> #define XATTR_NAME_CAPS XATTR_SECURITY_PREFIX XATTR_CAPS_SUFFIX
> 
> definitions from capability.h and puts them in xattr.h's #ifdef __KERNEL__ 
> section making them invisible to userspace like libcap-ng causing build 
> failures.
> 
> Am I wrong?

You're correct.  It's the same reason that cap-ng.c has to define
'security'.

#ifdef VFS_CAP_U32
 #include <attr/xattr.h>
 #define XATTR_SECURITY_PREFIX "security."

Am cc'ing Steve.

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-10-12 13:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-01 19:07 [PATCH] security: move LSM xattrnames to xattr.h Mimi Zohar
2010-07-02  0:16 ` James Morris
2010-10-12 11:14   ` Ozan Çağlayan
2010-10-12 13:06     ` Mimi Zohar [this message]
2010-10-12 13:19       ` Steve Grubb
2010-10-12 13:40         ` Mimi Zohar
2010-11-03 17:00           ` Steve Grubb
2010-11-03 17:38             ` Mimi Zohar
2010-11-03 17:57               ` Steve Grubb
2010-11-03 19:02                 ` Eric Paris
2010-11-03 19:46                   ` Steve Grubb
2010-11-03 20:26           ` Eric Paris
2010-11-03 20:45             ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286888769.2670.5.camel@localhost.localdomain \
    --to=zohar@linux.vnet.ibm.com \
    --cc=casey@schaufler-ca.com \
    --cc=dave@linux.vnet.ibm.com \
    --cc=jmorris@namei.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=ozan@pardus.org.tr \
    --cc=safford@watson.ibm.com \
    --cc=sgrubb@redhat.com \
    --cc=zohar@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).