From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: Re: [PATCH] security: move LSM xattrnames to xattr.h
Date: Tue, 12 Oct 2010 09:40:34 -0400
Message-ID: <1286890834.2670.21.camel@localhost.localdomain>
References: <1278011263-7951-1-git-send-email-zohar@linux.vnet.ibm.com>
	 <201010121414.14486.ozan@pardus.org.tr>
	 <1286888769.2670.5.camel@localhost.localdomain>
	 <201010120919.11819.sgrubb@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Ozan =?UTF-8?Q?=C3=87a=C4=9Flayan?= <ozan@pardus.org.tr>,
	James Morris <jmorris@namei.org>, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,
	Casey Schaufler <casey@schaufler-ca.com>,
	David Safford <safford@watson.ibm.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>,
	Mimi Zohar <zohar@us.ibm.com>
To: Steve Grubb <sgrubb@redhat.com>
Return-path: <linux-security-module-owner@vger.kernel.org>
In-Reply-To: <201010120919.11819.sgrubb@redhat.com>
Sender: linux-security-module-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Tue, 2010-10-12 at 09:19 -0400, Steve Grubb wrote:
> On Tuesday, October 12, 2010 09:06:09 am Mimi Zohar wrote:
> > On Tue, 2010-10-12 at 14:14 +0300, Ozan =C3=87a=C4=9Flayan wrote:
> > > Cuma 02 Temmuz 2010 g=C3=BCn=C3=BC (saat 03:16:01) James Morris =C5=
=9Funlar=C4=B1 yazm=C4=B1=C5=9Ft=C4=B1:
> > > > On Thu, 1 Jul 2010, Mimi Zohar wrote:
> > > > > Make the security extended attributes names global. Updated t=
o move
> > > > > the remaining Smack xattrs.
> > > > >=20
> > > > > Signed-off-by: Mimi Zohar <zohar@us.ibm.com>
> > > > > Acked-by: Serge Hallyn <serue@us.ibm.com>
> > >=20
> > > This drops
> > >=20
> > > #define XATTR_CAPS_SUFFIX "capability"
> > > #define XATTR_NAME_CAPS XATTR_SECURITY_PREFIX XATTR_CAPS_SUFFIX
> > >=20
> > > definitions from capability.h and puts them in xattr.h's #ifdef
> > > __KERNEL__ section making them invisible to userspace like libcap=
-ng
> > > causing build failures.
> > >=20
> > > Am I wrong?
> >=20
> > You're correct.  It's the same reason that cap-ng.c has to define
> > 'security'.
> >=20
> > #ifdef VFS_CAP_U32
> >  #include <attr/xattr.h>
> >  #define XATTR_SECURITY_PREFIX "security."
> >=20
> > Am cc'ing Steve.
>=20
> So does this mean I need to provide more definitions for libcap-ng to=
 work with=20
> future kernels or are you asking my opinion? My opinion is that if us=
er space=20
> needs it to work correctly, please let it be available so I don't hav=
e to make=20
> my own define which may be inaccurate one day.
>=20
> Thanks,
> -Steve

Before making any changes to the kernel xattr.h, I want to understand
the reason for two xattr.h files, one in /usr/include/linux/ and the
other in /usr/include/xattr/.  /usr/include/linux/xattr.h contains thos=
e
elements not defined as __kernel__, while /usr/include/xattr/xattr.h
contains that and other definitions.  Will changing the kernel xattr.h
version change both?

As long as we're making this change, should 'security' also be defined
outside of the __kernel__ definitions?

thanks,

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-securit=
y-module" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html