linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, hch@infradead.org,
	zohar@us.ibm.com, warthog9@kernel.org, david@fromorbit.com,
	jmorris@namei.org, kyle@mcmartin.ca, hpa@zytor.com,
	akpm@linux-foundation.org, mingo@elte.hu
Subject: Re: [PATCH 1/3] IMA: move read/write counters into struct inode
Date: Tue, 19 Oct 2010 18:49:06 -0400	[thread overview]
Message-ID: <1287528546.2530.277.camel@localhost.localdomain> (raw)
In-Reply-To: <AANLkTimL=eChoCQHGoiouE5s6dGG=n9ZAQGhW-RW+gDj@mail.gmail.com>

Executive summary of the day's work:
Yesterday morning: 944 bytes per inode in core
Yesterday night: 24 bytes per inode in core
Tonight: 4 bytes per inode in core.

That's a x236 time reduction in memory usage.  No I didn't even start
looking at a freezer.  Which could bring that 4 down to 0, but would add
a scalability penalty on all inodes when IMA was enabled.

The memory associated with inodes that IMA actually cares about has gone
from 312 to 320 bytes.  

I'm going to follow up with my patch series again but they aren't really
ready to be applied.  The IBM people who wrote IMA are reviewing them.
I have some questions if my RCU+RBTREE usage is valid/correct.  I'd
really like Al to take a close look at the last patch in the series to
make sure my use of i_writecount actually does what I want it to do...

-Eric


  parent reply	other threads:[~2010-10-19 22:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19  1:16 [PATCH 1/3] IMA: move read/write counters into struct inode Eric Paris
2010-10-19  1:16 ` [PATCH 2/3] IMA: only allocate iint when needed Eric Paris
2010-10-19  1:17 ` [PATCH 3/3] IMA: use rbtree instead of radix tree for inode information cache Eric Paris
2010-10-19  1:30 ` [PATCH 1/3] IMA: move read/write counters into struct inode Christoph Hellwig
2010-10-19  2:14   ` Eric Paris
2010-10-19  7:39     ` Dave Chinner
2010-10-19 16:24       ` Eric Paris
2010-10-19 16:29         ` Christoph Hellwig
2010-10-19  8:39     ` Ingo Molnar
2010-10-19  2:46 ` Eric Paris
2010-10-19 15:52 ` Linus Torvalds
2010-10-19 16:36   ` Eric Paris
2010-10-19 16:55     ` Al Viro
2010-10-19 17:03       ` Linus Torvalds
2010-10-19 17:28         ` Al Viro
2010-10-19 18:16           ` Mimi Zohar
2010-10-20 13:10             ` John Stoffel
2010-10-20 13:36               ` Al Viro
2010-10-20 14:09                 ` John Stoffel
2010-10-19 19:11           ` Matthew Wilcox
2010-10-20  3:15             ` Al Viro
2010-10-20 17:38               ` J. Bruce Fields
2010-10-19 22:49         ` Eric Paris [this message]
2010-10-20 14:38           ` Ingo Molnar
2010-10-20 14:46             ` Eric Paris
2010-10-20 15:15               ` Ingo Molnar
2010-10-20 15:25                 ` Eric Paris
2010-10-21 16:15                 ` Casey Schaufler
2010-10-22  8:48                   ` Ingo Molnar
2010-10-22 17:50                     ` Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287528546.2530.277.camel@localhost.localdomain \
    --to=eparis@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=hpa@zytor.com \
    --cc=jmorris@namei.org \
    --cc=kyle@mcmartin.ca \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=warthog9@kernel.org \
    --cc=zohar@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).