From: Dave Chinner <david@fromorbit.com>
To: viro@ZenIV.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: fs: break out inode operations from inode_lock V4
Date: Fri, 29 Oct 2010 19:59:55 +1100 [thread overview]
Message-ID: <1288342803-14957-1-git-send-email-david@fromorbit.com> (raw)
Hi Al,
Another update to the inode_lock splitting patch set. It's still
based on your merge-stem branch. I'm going to be out all weekend, so
any further changes will take a couple of days to turn around.
Version 4:
- whitespace cleanup
- moved setting state on new inodes till after the hash search fails
in insert_inode_locked
- made hash insert operations atomic with state changes by holding
inode->i_lock while doing hash inserts
- made inode hash removals atomic with state changes by taking the
inode_lock (later inode_hash_lock) and inode->i_lock. Combined
with the insert changes, this means the inode_unhashed check in
->drop_inode is safely protected by just holding the
inode->i_lock.
- protect inode_unhashed() checks in insert_inode_locked with
inode->i_lock
- cleaned up comments and documentation a bit more.
Version 3:
- remove up wake_up_inode() inode_lock avoidance optimisation as the
inode_lock is no longer protecting i_state.
- Added a BUG_ON() check to evict() to ensure that inodes are removed
from the LRU before being evicted.
- removed inode_lock from igrab() when removing inode_lock from the
first half of iput_final()
- added 3 patches to convert the per-sb inode list, the writeback lists and the
inode hashes under their own locks. The changes from the first version of
these patches (posted separately) are:
- cleaned up comment for writeback_single_inode()
- dropped __mark_inode_dirty() cleanup and just moved the minimum
amount of code around to handle the locking changes cleanly.
- moved adding inodes to sb list under the hash lock as well so we
don't have inodes that are not on the per-sb lists on the hash.
- added a patch to clean up inode_lock references in documentation and
comments.
Version 2:
- make i_state checks/__iget() atomic under inode->i_lock
- merge dispose_one_inode() into evict()
- move inode hash removal after ->evict_inode call.
- always take the inode_lru_lock() when checking whether the inode
is on the lru or not.
next reply other threads:[~2010-10-29 8:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 8:59 Dave Chinner [this message]
2010-10-29 8:59 ` [PATCH 1/8] fs: protect inode->i_state with inode->i_lock Dave Chinner
2010-10-29 8:59 ` [PATCH 2/8] fs: factor inode disposal Dave Chinner
2010-10-29 8:59 ` [PATCH 3/8] fs: Lock the inode LRU list separately Dave Chinner
2010-10-29 8:59 ` [PATCH 4/8] fs: remove inode_lock from iput_final and prune_icache Dave Chinner
2010-10-29 9:00 ` [PATCH 5/8] fs: move i_sb_list out from under inode_lock Dave Chinner
2010-10-29 9:00 ` [PATCH 6/8] fs: move i_wb_list " Dave Chinner
2010-10-29 9:43 ` Christoph Hellwig
2010-10-29 9:48 ` Al Viro
2010-10-29 9:00 ` [PATCH 7/8] fs: rename inode_lock to inode_hash_lock Dave Chinner
2010-10-29 9:00 ` [PATCH 8/8] fs: Clean up documentation references to inode_lock Dave Chinner
2010-10-29 9:29 ` fs: break out inode operations from inode_lock V4 Al Viro
2010-10-29 9:34 ` Dave Chinner
2010-11-09 3:43 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288342803-14957-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).