From: Eric Paris <eparis@redhat.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: Ensure FMODE_NONOTIFY is not set by userspace
Date: Fri, 29 Oct 2010 09:52:50 -0400 [thread overview]
Message-ID: <1288360370.3017.15.camel@localhost.localdomain> (raw)
In-Reply-To: <20101029100217.GC26242@lsanfilippo.unix.rd.tt.avira.com>
On Fri, 2010-10-29 at 12:02 +0200, Lino Sanfilippo wrote:
> In fsnotify_open() ensure that FMODE_NONOTIFY is never set by userspace.
> Also always call fsnotify_parent and fsnotify.
Did you find a place where the user was able to set FMODE_NONOTIFY?
That would be a problem. But that's not what is happening here and
that's not what you are fixing.
This is a test if FMODE_NONOTIFY was already set then we do not send
notification about that file. The current code is correct and your
patch breaks it....
-Eric
next prev parent reply other threads:[~2010-10-29 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 10:02 Ensure FMODE_NONOTIFY is not set by userspace Lino Sanfilippo
2010-10-29 13:52 ` Eric Paris [this message]
2010-10-29 14:27 ` Lino Sanfilippo
2010-10-29 16:10 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288360370.3017.15.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=LinoSanfilippo@gmx.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).