From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Paris Subject: Re: Ensure FMODE_NONOTIFY is not set by userspace Date: Fri, 29 Oct 2010 09:52:50 -0400 Message-ID: <1288360370.3017.15.camel@localhost.localdomain> References: <20101029100217.GC26242@lsanfilippo.unix.rd.tt.avira.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Lino Sanfilippo Return-path: In-Reply-To: <20101029100217.GC26242@lsanfilippo.unix.rd.tt.avira.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 2010-10-29 at 12:02 +0200, Lino Sanfilippo wrote: > In fsnotify_open() ensure that FMODE_NONOTIFY is never set by userspace. > Also always call fsnotify_parent and fsnotify. Did you find a place where the user was able to set FMODE_NONOTIFY? That would be a problem. But that's not what is happening here and that's not what you are fixing. This is a test if FMODE_NONOTIFY was already set then we do not send notification about that file. The current code is correct and your patch breaks it.... -Eric