From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Paris Subject: Re: [PATCH] make fanotify_read() restartable across signals Date: Fri, 29 Oct 2010 09:53:48 -0400 Message-ID: <1288360428.3017.16.camel@localhost.localdomain> References: <20101029100642.GD26242@lsanfilippo.unix.rd.tt.avira.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Lino Sanfilippo Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21403 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757785Ab0J2Nxw (ORCPT ); Fri, 29 Oct 2010 09:53:52 -0400 In-Reply-To: <20101029100642.GD26242@lsanfilippo.unix.rd.tt.avira.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 2010-10-29 at 12:06 +0200, Lino Sanfilippo wrote: > In fanotify_read() return -ERESTARTSYS instead of -EINTR to > make read() restartable across signals (BSD semantic). Looks good, I'll add it today. Thanks! -Eric > --- > This patch applies against commit 3970d817558a426cc2f53eaa01182eb9452e0cb1 > of branch 'origin/for-next' from git.infradead.org/users/eparis/notify.git > > diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c > index 8c9fd35..99a8e60 100644 > --- a/fs/notify/fanotify/fanotify_user.c > +++ b/fs/notify/fanotify/fanotify_user.c > @@ -330,7 +330,7 @@ static ssize_t fanotify_read(struct file *file, char __user *buf, > ret = -EAGAIN; > if (file->f_flags & O_NONBLOCK) > break; > - ret = -EINTR; > + ret = -ERESTARTSYS; > if (signal_pending(current)) > break; >