From: Eric Paris <eparis@redhat.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fanotify: Do check against max_marks and increase number of group marks atomically
Date: Tue, 09 Nov 2010 15:21:45 -0500 [thread overview]
Message-ID: <1289334105.3083.30.camel@localhost.localdomain> (raw)
In-Reply-To: <20101109181904.GB5867@lsanfilippo.unix.rd.tt.avira.com>
On Tue, 2010-11-09 at 19:19 +0100, Lino Sanfilippo wrote:
> The number of group marks is checked against max_marks and increased afterwards
> in a non atomic way. This may result in 2 or more processes passing the check
> at the same time and increasing the number of group marks above the max_marks
> limit afterwards.
> With this patch the check against max_marks is done in fsnotify_add_mark(),
> after the group lock has been aquired to ensure that concurrent processes
> cant exceed the group marks limit.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
applied to http://git.infradead.org/users/eparis/notify.git/ #for-next
-Eric
prev parent reply other threads:[~2010-11-09 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 18:19 [PATCH] fanotify: Do check against max_marks and increase number of group marks atomically Lino Sanfilippo
2010-11-09 20:21 ` Eric Paris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289334105.3083.30.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=LinoSanfilippo@gmx.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).