From: Andy Whitcroft <apw@canonical.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
vaurora@redhat.com, neilb@suse.de, viro@zeniv.linux.org.uk,
Andy Whitcroft <apw@canonical.com>
Subject: [PATCH 2/2] overlayfs: ovl_copy_up_xattr -- handle EOPNOTSUPP from vfs_listxattr
Date: Wed, 17 Nov 2010 17:37:04 +0000 [thread overview]
Message-ID: <1290015424-5583-3-git-send-email-apw@canonical.com> (raw)
In-Reply-To: <1290015424-5583-1-git-send-email-apw@canonical.com>
Even when an underlying filesystem had a getxattr op it may not support
xattrs. In this case vfs_listxattr will return EOPNOTSUPP. Handle
this return when copying up attributes.
Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
fs/overlayfs/overlayfs.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/overlayfs/overlayfs.c b/fs/overlayfs/overlayfs.c
index 6b8a7b9..1148b8c 100644
--- a/fs/overlayfs/overlayfs.c
+++ b/fs/overlayfs/overlayfs.c
@@ -692,8 +692,11 @@ static int ovl_copy_up_xattr(struct dentry *old, struct dentry *new)
return 0;
list_size = vfs_listxattr(old, NULL, 0);
- if (list_size <= 0)
+ if (list_size <= 0) {
+ if (list_size == -EOPNOTSUPP)
+ return 0;
return list_size;
+ }
buf = kzalloc(list_size, GFP_KERNEL);
if (!buf)
--
1.7.0.4
next prev parent reply other threads:[~2010-11-17 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 17:37 [PATCH 0/2] overlayfs fixes Andy Whitcroft
2010-11-17 17:37 ` [PATCH 1/2] overlayfs: handle missing lower inodes in ovl_is_same_inode Andy Whitcroft
2010-11-17 17:37 ` Andy Whitcroft [this message]
2010-11-25 15:06 ` [PATCH 0/2] overlayfs fixes Miklos Szeredi
2010-11-28 19:18 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290015424-5583-3-git-send-email-apw@canonical.com \
--to=apw@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.de \
--cc=vaurora@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).