From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Paris Subject: Re: [PATCH] fanotify: Dont allow a mask of 0 if setting or removing a mark Date: Tue, 23 Nov 2010 14:54:36 -0500 Message-ID: <1290542076.1443.33.camel@localhost.localdomain> References: <20101122174633.GB5512@lsanfilippo.unix.rd.tt.avira.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Lino Sanfilippo Return-path: In-Reply-To: <20101122174633.GB5512@lsanfilippo.unix.rd.tt.avira.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 2010-11-22 at 18:46 +0100, Lino Sanfilippo wrote: > In mark_remove_from_mask() we destroy marks that have their event mask cleared. > Thus we should not allow the creation of those marks in the first place. > With this patch we check if the mask given from user is 0 in case of FAN_MARK_ADD. > If so we return an error. Same for FAN_MARK_REMOVE since this does not have any > effect. > > Signed-off-by: Lino Sanfilippo applied. Thanks.