linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <josef@redhat.com>
To: linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org,
	swhiteho@redhat.com
Subject: [PATCH] fs: make block fiemap mapping length at least blocksize long
Date: Wed,  8 Dec 2010 12:03:10 -0500	[thread overview]
Message-ID: <1291827790-21377-1-git-send-email-josef@redhat.com> (raw)

Some filesystems don't deal well with being asked to map less than blocksize
blocks (GFS2 for example).  Since we are always mapping at least blocksize
sections anyway, just make sure len is at least as big as a blocksize so we
don't trip up any filesystems.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>
---
 fs/ioctl.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/fs/ioctl.c b/fs/ioctl.c
index d6cc164..6b53c24 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -273,6 +273,13 @@ int __generic_block_fiemap(struct inode *inode,
 		len = isize;
 	}
 
+	/*
+	 * Some filesystems can't deal with being asked to map less than
+	 * blocksize, so make sure our len is at least block length.
+	 */
+	if (logical_to_blk(inode, len) == 0)
+		len = blk_to_logical(inode, 1);
+
 	start_blk = logical_to_blk(inode, start);
 	last_blk = logical_to_blk(inode, start + len - 1);
 
-- 
1.6.6.1


             reply	other threads:[~2010-12-08 17:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-08 17:03 Josef Bacik [this message]
2011-02-01 11:46 ` [PATCH] fs: make block fiemap mapping length at least blocksize long Steven Whitehouse
2011-02-01 20:28   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291827790-21377-1-git-send-email-josef@redhat.com \
    --to=josef@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).