From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Salikhmetov Subject: [PATCH 1/1] hfsplus: fix an artifact in ioctl flag checking Date: Thu, 16 Dec 2010 14:44:51 +0200 Message-ID: <1292503491-28630-1-git-send-email-alexo@tuxera.com> To: linux-fsdevel@vger.kernel.org, hch@tuxera.com Return-path: Received: from mail-fx0-f43.google.com ([209.85.161.43]:42581 "EHLO mail-fx0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456Ab0LPMpI (ORCPT ); Thu, 16 Dec 2010 07:45:08 -0500 Received: by fxm18 with SMTP id 18so3207155fxm.2 for ; Thu, 16 Dec 2010 04:45:07 -0800 (PST) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Fix a flag checking artifact in hfsplus_ioctl_getflags() routine found while doing clean-up against assignments inside `if's. Signed-off-by: Anton Salikhmetov --- fs/hfsplus/ioctl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/hfsplus/ioctl.c b/fs/hfsplus/ioctl.c index 40a85a3..4caa3dc 100644 --- a/fs/hfsplus/ioctl.c +++ b/fs/hfsplus/ioctl.c @@ -28,7 +28,7 @@ static int hfsplus_ioctl_getflags(struct file *file, int __user *user_flags) if (inode->i_flags & S_IMMUTABLE) flags |= FS_IMMUTABLE_FL; - if (inode->i_flags |= S_APPEND) + if (inode->i_flags & S_APPEND) flags |= FS_APPEND_FL; if (hip->userflags & HFSPLUS_FLG_NODUMP) flags |= FS_NODUMP_FL; -- 1.7.2.3