* [PATCH 1/2] Ext2: return ENOMEM rather than EIO if sb_getblk fails
@ 2011-01-13 10:46 Wang shilong
0 siblings, 0 replies; 2+ messages in thread
From: Wang shilong @ 2011-01-13 10:46 UTC (permalink / raw)
To: jack; +Cc: linux-fsdevel, tytso, linux-ext4, Wang shilong, Wang Shilong
From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
As the only reason that sb_getblk fails is that allocation fails.
It will be better to use ENOMEM rather than EIO.
Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
---
fs/ext2/super.c | 2 +-
fs/ext2/xattr.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 663fdcd..3308a55 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1457,7 +1457,7 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
else
bh = sb_getblk(sb, tmp_bh.b_blocknr);
if (unlikely(!bh)) {
- err = -EIO;
+ err = -ENOMEM;
goto out;
}
lock_buffer(bh);
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
index 06209ec..2d7557d 100644
--- a/fs/ext2/xattr.c
+++ b/fs/ext2/xattr.c
@@ -665,7 +665,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh,
if (unlikely(!new_bh)) {
ext2_free_blocks(inode, block, 1);
mark_inode_dirty(inode);
- error = -EIO;
+ error = -ENOMEM;
goto cleanup;
}
lock_buffer(new_bh);
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 1/2] Ext2: return ENOMEM rather than EIO if sb_getblk fails
@ 2011-01-13 10:53 Wang shilong
0 siblings, 0 replies; 2+ messages in thread
From: Wang shilong @ 2011-01-13 10:53 UTC (permalink / raw)
To: 272316530; +Cc: Wang shilong, Wang Shilong
From: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
As the only reason that sb_getblk fails is that allocation fails.
It will be better to use ENOMEM rather than EIO.
Signed-off-by: Wang Shilong <wangsl-fnst@cn.fujitsu.com>
---
fs/ext2/super.c | 2 +-
fs/ext2/xattr.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 663fdcd..3308a55 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1457,7 +1457,7 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
else
bh = sb_getblk(sb, tmp_bh.b_blocknr);
if (unlikely(!bh)) {
- err = -EIO;
+ err = -ENOMEM;
goto out;
}
lock_buffer(bh);
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
index 06209ec..2d7557d 100644
--- a/fs/ext2/xattr.c
+++ b/fs/ext2/xattr.c
@@ -665,7 +665,7 @@ ext2_xattr_set2(struct inode *inode, struct buffer_head *old_bh,
if (unlikely(!new_bh)) {
ext2_free_blocks(inode, block, 1);
mark_inode_dirty(inode);
- error = -EIO;
+ error = -ENOMEM;
goto cleanup;
}
lock_buffer(new_bh);
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-13 4:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-13 10:46 [PATCH 1/2] Ext2: return ENOMEM rather than EIO if sb_getblk fails Wang shilong
-- strict thread matches above, loose matches on Subject: below --
2011-01-13 10:53 Wang shilong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).