* [PATCH] btrfs: compile fix
@ 2011-01-15 15:33 James Bottomley
2011-01-15 21:07 ` Jeff Garzik
2011-01-15 23:30 ` Chris Mason
0 siblings, 2 replies; 3+ messages in thread
From: James Bottomley @ 2011-01-15 15:33 UTC (permalink / raw)
To: Chris Mason; +Cc: linux-fsdevel
Could we please fix this problem:
In file included from fs/btrfs/ctree.c:21:
fs/btrfs/ctree.h:1003: error: field 'super_kobj' has incomplete type
fs/btrfs/ctree.h:1074: error: field 'root_kobj' has incomplete type
make[2]: *** [fs/btrfs/ctree.o] Error 1
It's annoying all my builds at the moment.
James
---
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index a142d20..f4f5fd5 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -25,6 +25,7 @@
#include <linux/fs.h>
#include <linux/completion.h>
#include <linux/backing-dev.h>
+#include <linux/kobject.h>
#include <linux/wait.h>
#include <linux/slab.h>
#include <asm/kmap_types.h>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: compile fix
2011-01-15 15:33 [PATCH] btrfs: compile fix James Bottomley
@ 2011-01-15 21:07 ` Jeff Garzik
2011-01-15 23:30 ` Chris Mason
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2011-01-15 21:07 UTC (permalink / raw)
To: James Bottomley; +Cc: Chris Mason, linux-fsdevel, Linus Torvalds
On 01/15/2011 10:33 AM, James Bottomley wrote:
> Could we please fix this problem:
>
> In file included from fs/btrfs/ctree.c:21:
> fs/btrfs/ctree.h:1003: error: field 'super_kobj' has incomplete type
> fs/btrfs/ctree.h:1074: error: field 'root_kobj' has incomplete type
> make[2]: *** [fs/btrfs/ctree.o] Error 1
>
> It's annoying all my builds at the moment.
>
> James
>
> ---
>
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index a142d20..f4f5fd5 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -25,6 +25,7 @@
> #include<linux/fs.h>
> #include<linux/completion.h>
> #include<linux/backing-dev.h>
> +#include<linux/kobject.h>
> #include<linux/wait.h>
> #include<linux/slab.h>
> #include<asm/kmap_types.h>
This has been broken for a day or three, and the fix is obvious.
Please forward to Linus. It's annoying everybody. :)
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: compile fix
2011-01-15 15:33 [PATCH] btrfs: compile fix James Bottomley
2011-01-15 21:07 ` Jeff Garzik
@ 2011-01-15 23:30 ` Chris Mason
1 sibling, 0 replies; 3+ messages in thread
From: Chris Mason @ 2011-01-15 23:30 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-fsdevel
Excerpts from James Bottomley's message of 2011-01-15 10:33:55 -0500:
> Could we please fix this problem:
>
> In file included from fs/btrfs/ctree.c:21:
> fs/btrfs/ctree.h:1003: error: field 'super_kobj' has incomplete type
> fs/btrfs/ctree.h:1074: error: field 'root_kobj' has incomplete type
> make[2]: *** [fs/btrfs/ctree.o] Error 1
Yes, my pull request is going out this weekend.
-chris
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-15 23:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-15 15:33 [PATCH] btrfs: compile fix James Bottomley
2011-01-15 21:07 ` Jeff Garzik
2011-01-15 23:30 ` Chris Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).