linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Joel Becker <jlbec@evilplan.org>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	James Bottomley <James.Bottomley@suse.de>,
	Nicholas Bellinger <nab@linux-iscsi.org>
Subject: [PATCH] configfs: change depends -> select SYSFS
Date: Sat, 15 Jan 2011 13:10:51 -0800	[thread overview]
Message-ID: <1295125851-25279-1-git-send-email-nab@linux-iscsi.org> (raw)

From: Nicholas Bellinger <nab@linux-iscsi.org>

Hi Linus,

The following patch should be included for 38-rc1 to fix a rdd
reported linux-next kbuild warning introduced by TARGET_CORE
using 'select CONFIGFS_FS' from over the holidays, that was not
included with the initial target merge yesterday.

Thanks!

----------------------------------------------------------------

This patch changes configfs to select SYSFS to fix the following:

warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)

This patch also fixes whitespace breakage in the 'help' section.

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
---
 fs/configfs/Kconfig |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/fs/configfs/Kconfig b/fs/configfs/Kconfig
index 13587cc..0e4bd23 100644
--- a/fs/configfs/Kconfig
+++ b/fs/configfs/Kconfig
@@ -1,11 +1,11 @@
 config CONFIGFS_FS
 	tristate "Userspace-driven configuration filesystem"
-	depends on SYSFS
+	select SYSFS
 	help
-	  configfs is a ram-based filesystem that provides the converse
-	  of sysfs's functionality. Where sysfs is a filesystem-based
-	  view of kernel objects, configfs is a filesystem-based manager
-	  of kernel objects, or config_items.
+	configfs is a RAM-based filesystem that provides the converse
+	of sysfs's functionality. Where sysfs is a filesystem-based
+	view of kernel objects, configfs is a filesystem-based manager
+	of kernel objects, or config_items.
 
-	  Both sysfs and configfs can and should exist together on the
-	  same system. One is not a replacement for the other.
+	Both sysfs and configfs can and should exist together on the
+	same system. One is not a replacement for the other.
-- 
1.7.3.5

             reply	other threads:[~2011-01-15 21:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-15 21:10 Nicholas A. Bellinger [this message]
2011-01-16 13:11 ` [PATCH] configfs: change depends -> select SYSFS Stefan Richter
2011-01-16 21:53   ` Nicholas A. Bellinger
2011-01-16 23:06     ` Stefan Richter
2011-01-16 23:11       ` Linus Torvalds
2011-01-16 23:19         ` Al Viro
2011-01-16 23:45           ` Linus Torvalds
2011-01-17  0:05             ` Al Viro
2011-01-17  7:11               ` Rolf Eike Beer
2011-01-17  0:52             ` Stefan Richter
2011-01-17  1:07               ` Randy Dunlap
2011-01-17 11:16               ` Bernd Petrovitsch
2011-01-16 23:14       ` Nicholas A. Bellinger
2011-01-17  0:22       ` James Bottomley
2011-01-17  6:05         ` Nicholas A. Bellinger
2011-01-17 18:24           ` Randy Dunlap
2011-01-17 22:10             ` Nicholas A. Bellinger
2011-01-18  0:13               ` Randy Dunlap
2011-01-18  0:46                 ` Nicholas A. Bellinger
2011-01-17 18:11         ` Randy Dunlap
2011-01-16 17:54 ` Linus Torvalds
2011-01-16 21:44   ` Nicholas A. Bellinger
  -- strict thread matches above, loose matches on Subject: below --
2011-01-10 19:45 Nicholas A. Bellinger
2011-01-10 23:46 ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295125851-25279-1-git-send-email-nab@linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=James.Bottomley@suse.de \
    --cc=jlbec@evilplan.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).