From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Joel Becker <jlbec@evilplan.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
James Bottomley <James.Bottomley@suse.de>
Subject: Re: [PATCH] configfs: change depends -> select SYSFS
Date: Sun, 16 Jan 2011 13:53:27 -0800 [thread overview]
Message-ID: <1295214807.22813.57.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20110116141105.59e5b3a2@stein>
On Sun, 2011-01-16 at 14:11 +0100, Stefan Richter wrote:
> On Jan 15 Nicholas A. Bellinger wrote:
> > This patch changes configfs to select SYSFS to fix the following:
> >
> > warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
>
> Why don't you fix target-core's Kconfig instead?
The thought here was that since modern configfs is mounted
at /sys/kernel/config/, selecting SYSFS by default when building
CONFIGFS_FS made the most sense for existing configfs consumers.
> > This patch also fixes whitespace breakage in the 'help' section.
>
> There is no whitespace breakage in fs/configfs/Kconfig.
Fixed in scsi-post-merge-2.6.git/for-linus. Thanks for your comments!
--nab
next prev parent reply other threads:[~2011-01-16 21:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 21:10 [PATCH] configfs: change depends -> select SYSFS Nicholas A. Bellinger
2011-01-16 13:11 ` Stefan Richter
2011-01-16 21:53 ` Nicholas A. Bellinger [this message]
2011-01-16 23:06 ` Stefan Richter
2011-01-16 23:11 ` Linus Torvalds
2011-01-16 23:19 ` Al Viro
2011-01-16 23:45 ` Linus Torvalds
2011-01-17 0:05 ` Al Viro
2011-01-17 7:11 ` Rolf Eike Beer
2011-01-17 0:52 ` Stefan Richter
2011-01-17 1:07 ` Randy Dunlap
2011-01-17 11:16 ` Bernd Petrovitsch
2011-01-16 23:14 ` Nicholas A. Bellinger
2011-01-17 0:22 ` James Bottomley
2011-01-17 6:05 ` Nicholas A. Bellinger
2011-01-17 18:24 ` Randy Dunlap
2011-01-17 22:10 ` Nicholas A. Bellinger
2011-01-18 0:13 ` Randy Dunlap
2011-01-18 0:46 ` Nicholas A. Bellinger
2011-01-17 18:11 ` Randy Dunlap
2011-01-16 17:54 ` Linus Torvalds
2011-01-16 21:44 ` Nicholas A. Bellinger
-- strict thread matches above, loose matches on Subject: below --
2011-01-10 19:45 Nicholas A. Bellinger
2011-01-10 23:46 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295214807.22813.57.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=James.Bottomley@suse.de \
--cc=jlbec@evilplan.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).