From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Paris Subject: Re: Q. FMODE_NONOTIFY warning Date: Wed, 19 Jan 2011 14:21:32 -0500 Message-ID: <1295464892.21577.25.camel@localhost.localdomain> References: <7545.1282138784@jrobl> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org To: "J. R. Okajima" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9975 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754675Ab1ASTVi (ORCPT ); Wed, 19 Jan 2011 14:21:38 -0500 In-Reply-To: <7545.1282138784@jrobl> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 2010-08-18 at 22:39 +0900, J. R. Okajima wrote: > By the commit > ecf081d 2010-07-28 vfs: introduce FMODE_NONOTIFY > a new warning is produced. > > In include/linux/fs.h > #define FMODE_NONOTIFY ((__force fmode_t)0x1000000) > ::: > #define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE) | \ > (flag & FMODE_NONOTIFY))) > > In fs/anon_inodes.c > anon_inode_getfile(..., int flags) > { > file = alloc_file(&path, OPEN_FMODE(flags), fops); > } > > Here the '&' operator handles the passed integer "flags" and "__force > fmode_t", and we get "warning: restricted fmode_t degrades to integer". > > Can we stop this warning? I apologize that this e-mail (along with many others) got put in my spam folder and I'm responding months and months late. I don't believe this is a problem upstream any longer. Thanks for the report and I'm sorry I didn't respond.... -Eric