From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shaohua Li Subject: Re: [PATCH v3 1/5] add metadata_incore ioctl in vfs Date: Thu, 20 Jan 2011 14:12:33 +0800 Message-ID: <1295503953.1949.928.camel@sli10-conroe> References: <1295399718.1949.864.camel@sli10-conroe> <20110119124158.b0348c44.akpm@linux-foundation.org> <1295490647.1949.890.camel@sli10-conroe> <20110119184240.b0a6a016.akpm@linux-foundation.org> <1295491713.1949.898.camel@sli10-conroe> <20110119190548.e1f7f01f.akpm@linux-foundation.org> <1295493709.1949.910.camel@sli10-conroe> <20110119201014.adf02a78.akpm@linux-foundation.org> <1295501898.1949.917.camel@sli10-conroe> <20110119215510.0882db92.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Chris Mason , Christoph Hellwig , Arjan van de Ven , "Yan, Zheng" , "Wu, Fengguang" , linux-api , manpages To: Andrew Morton Return-path: In-Reply-To: <20110119215510.0882db92.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 2011-01-20 at 13:55 +0800, Andrew Morton wrote: > On Thu, 20 Jan 2011 13:38:18 +0800 Shaohua Li wrote: > > > > ext2, minix and probably others create an address_space for each > > > directory. Heaven knows what xfs does (for example). > > yes, this is for one directiory, but the all files's metadata are in > > block_dev address_space. > > I thought you mean there are several block_dev address_space like > > address_space in some filesystems, which doesn't fit well in my > > implementation. for ext like filesystem, there is only one > > address_space. for filesystems with several address_space, my proposal > > is map them to a virtual big address_space in the new ioctls. > > ext2 and minixfs (and I think sysv and ufs) have a separate > address_space for each directory. I don't see how those can be > represented with a single "virtual big address_space" - we also need > identifiers in there so each directory's address_space can be created > and appropriately populated. Oh, I misunderstand your comments. you are right, the ioctl methods don't work for ext2. the dir's address_space can't be readahead either. Looks we could only do the metadata readahead in filesystem specific way. Thanks, Shaohua