From: Tao Ma <tm@tao.ma>
To: linux-fsdevel@vger.kernel.org
Cc: linux-ext4@vger.kernel.org, Nick Piggin <npiggin@kernel.dk>,
Al Viro <viro@zeniv.linux.org.uk>,
Chris Mason <chris.mason@oracle.com>,
Boaz Harrosh <bharrosh@panasas.com>
Subject: [PATCH] VFS: call synchronize_rcu after kill_sb.
Date: Sat, 5 Feb 2011 17:01:21 +0800 [thread overview]
Message-ID: <1296896481-3650-1-git-send-email-tm@tao.ma> (raw)
From: Tao Ma <boyu.mt@taobao.com>
In fa0d7e3, we use rcu free inode instead of freeing the inode
directly. It causes a problem when we rmmod immediately after
we umount the volume[1].
So we need to call synchronize_rcu after we kill_sb so that
the inode is freed before we do rmmod. The idea is inspired
by Chris Mason[2]. I tested with ext4 by umount+rmmod and it
doesn't show any error by now.
1. http://marc.info/?l=linux-fsdevel&m=129680863330185&w=2
2. http://marc.info/?l=linux-fsdevel&m=129684698713709&w=2
Cc: Nick Piggin <npiggin@kernel.dk>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
fs/super.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/fs/super.c b/fs/super.c
index 74e149e..315bce9 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -177,6 +177,13 @@ void deactivate_locked_super(struct super_block *s)
struct file_system_type *fs = s->s_type;
if (atomic_dec_and_test(&s->s_active)) {
fs->kill_sb(s);
+ /*
+ * We need to synchronize rcu here so that
+ * the delayed rcu inode free can be executed
+ * before we put_super.
+ * https://bugzilla.kernel.org/show_bug.cgi?id=27652
+ */
+ synchronize_rcu();
put_filesystem(fs);
put_super(s);
} else {
--
1.6.3.GIT
next reply other threads:[~2011-02-05 9:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-05 9:01 Tao Ma [this message]
2011-02-07 13:14 ` [PATCH] VFS: call synchronize_rcu after kill_sb Boaz Harrosh
2011-02-08 16:57 ` Aneesh Kumar K. V
2011-02-08 17:25 ` Boaz Harrosh
2011-02-09 1:49 ` Tao Ma
2011-02-09 4:50 ` Christoph Hellwig
2011-02-09 8:26 ` [PATCH] VFS: call rcu_barrier " Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296896481-3650-1-git-send-email-tm@tao.ma \
--to=tm@tao.ma \
--cc=bharrosh@panasas.com \
--cc=chris.mason@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).