* [PATCH] zcache: Fix build error when sysfs is not defined
@ 2011-02-12 4:14 Nitin Gupta
2011-08-04 22:05 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Nitin Gupta @ 2011-02-12 4:14 UTC (permalink / raw)
To: Andrew Morton
Cc: Dan Magenheimer, Randy Dunlap, Valdis Kletnieks, linux-mm,
linux-kernel, linux-fsdevel
Signed-off-by: Nitin Gupta <ngupta@vflare.org>
---
drivers/staging/zcache/zcache.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/zcache/zcache.c b/drivers/staging/zcache/zcache.c
index 61be849..8cd3fd8 100644
--- a/drivers/staging/zcache/zcache.c
+++ b/drivers/staging/zcache/zcache.c
@@ -1590,9 +1590,9 @@ __setup("nofrontswap", no_frontswap);
static int __init zcache_init(void)
{
-#ifdef CONFIG_SYSFS
int ret = 0;
+#ifdef CONFIG_SYSFS
ret = sysfs_create_group(mm_kobj, &zcache_attr_group);
if (ret) {
pr_err("zcache: can't create sysfs\n");
--
1.7.3.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] zcache: Fix build error when sysfs is not defined
2011-02-12 4:14 [PATCH] zcache: Fix build error when sysfs is not defined Nitin Gupta
@ 2011-08-04 22:05 ` Randy Dunlap
2011-08-04 22:11 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2011-08-04 22:05 UTC (permalink / raw)
To: Nitin Gupta, Stephen Rothwell, gregkh
Cc: Andrew Morton, Dan Magenheimer, Valdis Kletnieks, linux-mm,
linux-kernel, linux-fsdevel
On Fri, 11 Feb 2011 23:14:39 -0500 Nitin Gupta wrote:
> Signed-off-by: Nitin Gupta <ngupta@vflare.org>
> ---
> drivers/staging/zcache/zcache.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/zcache/zcache.c b/drivers/staging/zcache/zcache.c
> index 61be849..8cd3fd8 100644
> --- a/drivers/staging/zcache/zcache.c
> +++ b/drivers/staging/zcache/zcache.c
> @@ -1590,9 +1590,9 @@ __setup("nofrontswap", no_frontswap);
>
> static int __init zcache_init(void)
> {
> -#ifdef CONFIG_SYSFS
> int ret = 0;
>
> +#ifdef CONFIG_SYSFS
> ret = sysfs_create_group(mm_kobj, &zcache_attr_group);
> if (ret) {
> pr_err("zcache: can't create sysfs\n");
> --
OMG. This patch still needs to be applied to linux-next 20110804..........
sad.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] zcache: Fix build error when sysfs is not defined
2011-08-04 22:05 ` Randy Dunlap
@ 2011-08-04 22:11 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2011-08-04 22:11 UTC (permalink / raw)
To: Randy Dunlap
Cc: Nitin Gupta, Stephen Rothwell, Andrew Morton, Dan Magenheimer,
Valdis Kletnieks, linux-mm, linux-kernel, linux-fsdevel
On Thu, Aug 04, 2011 at 03:05:24PM -0700, Randy Dunlap wrote:
> On Fri, 11 Feb 2011 23:14:39 -0500 Nitin Gupta wrote:
>
> > Signed-off-by: Nitin Gupta <ngupta@vflare.org>
> > ---
> > drivers/staging/zcache/zcache.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/zcache/zcache.c b/drivers/staging/zcache/zcache.c
> > index 61be849..8cd3fd8 100644
> > --- a/drivers/staging/zcache/zcache.c
> > +++ b/drivers/staging/zcache/zcache.c
> > @@ -1590,9 +1590,9 @@ __setup("nofrontswap", no_frontswap);
> >
> > static int __init zcache_init(void)
> > {
> > -#ifdef CONFIG_SYSFS
> > int ret = 0;
> >
> > +#ifdef CONFIG_SYSFS
> > ret = sysfs_create_group(mm_kobj, &zcache_attr_group);
> > if (ret) {
> > pr_err("zcache: can't create sysfs\n");
> > --
>
> OMG. This patch still needs to be applied to linux-next 20110804..........
> sad.
Heh, thanks, I'll queue it up soon.
greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-04 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-12 4:14 [PATCH] zcache: Fix build error when sysfs is not defined Nitin Gupta
2011-08-04 22:05 ` Randy Dunlap
2011-08-04 22:11 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).