linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: v9fs-developer@lists.sourceforge.net
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH 09/14] fs/9p: Mark inode attr invalid on setattr
Date: Thu, 17 Feb 2011 23:32:00 +0530	[thread overview]
Message-ID: <1297965725-25603-10-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1297965725-25603-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 fs/9p/vfs_inode.c      |    9 ++++++++-
 fs/9p/vfs_inode_dotl.c |    8 +++++++-
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index 21d36c7..e3597eb 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -958,9 +958,10 @@ v9fs_vfs_getattr(struct vfsmount *mnt, struct dentry *dentry,
 static int v9fs_vfs_setattr(struct dentry *dentry, struct iattr *iattr)
 {
 	int retval;
-	struct v9fs_session_info *v9ses;
 	struct p9_fid *fid;
 	struct p9_wstat wstat;
+	struct v9fs_session_info *v9ses;
+
 
 	P9_DPRINTK(P9_DEBUG_VFS, "\n");
 	retval = -EPERM;
@@ -993,6 +994,12 @@ static int v9fs_vfs_setattr(struct dentry *dentry, struct iattr *iattr)
 	retval = p9_client_wstat(fid, &wstat);
 	if (retval < 0)
 		return retval;
+	/*
+	 * Changing some of the attribute can result in
+	 * implicit update of other attributes. So mark
+	 * all of them invalid
+	 */
+	v9fs_invalidate_inode_attr(dentry->d_inode);
 
 	if ((iattr->ia_valid & ATTR_SIZE) &&
 	    iattr->ia_size != i_size_read(dentry->d_inode)) {
diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c
index 1cab2b5..81b2b4f 100644
--- a/fs/9p/vfs_inode_dotl.c
+++ b/fs/9p/vfs_inode_dotl.c
@@ -436,9 +436,9 @@ v9fs_vfs_getattr_dotl(struct vfsmount *mnt, struct dentry *dentry,
 int v9fs_vfs_setattr_dotl(struct dentry *dentry, struct iattr *iattr)
 {
 	int retval;
-	struct v9fs_session_info *v9ses;
 	struct p9_fid *fid;
 	struct p9_iattr_dotl p9attr;
+	struct v9fs_session_info *v9ses;
 
 	P9_DPRINTK(P9_DEBUG_VFS, "\n");
 
@@ -465,6 +465,12 @@ int v9fs_vfs_setattr_dotl(struct dentry *dentry, struct iattr *iattr)
 	retval = p9_client_setattr(fid, &p9attr);
 	if (retval < 0)
 		return retval;
+	/*
+	 * Changing some of the attribute can result in
+	 * implicit update of other attributes. So mark
+	 * all of them invalid
+	 */
+	v9fs_invalidate_inode_attr(dentry->d_inode);
 
 	if ((iattr->ia_valid & ATTR_SIZE) &&
 	    iattr->ia_size != i_size_read(dentry->d_inode)) {
-- 
1.7.1


  parent reply	other threads:[~2011-02-17 18:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-17 18:01 [PATCH -V3] Buffered write and writeable mmap support for 9P Aneesh Kumar K.V
2011-02-17 18:01 ` [PATCH 01/14] fs/9p: Fix inode i_size update in file_write Aneesh Kumar K.V
2011-02-17 18:01 ` [PATCH 02/14] fs/9p: Add direct IO support in cached mode Aneesh Kumar K.V
2011-02-17 18:01 ` [PATCH 03/14] fs/9p: Add drop_inode 9p callback Aneesh Kumar K.V
2011-02-17 18:01 ` [PATCH 04/14] fs/9p: Drop the directory link count correctly Aneesh Kumar K.V
2011-02-17 18:01 ` [PATCH 05/14] fs/9p: Update link count correctly during rename Aneesh Kumar K.V
2011-02-17 18:01 ` [PATCH 06/14] fs/9p: Update link count correctly on mkdir Aneesh Kumar K.V
2011-02-17 18:01 ` [PATCH 07/14] fs/9p: Initialize root inode number for dotl Aneesh Kumar K.V
2011-02-17 18:01 ` [PATCH 08/14] fs/9p: Add support for marking inode attribute invalid Aneesh Kumar K.V
2011-02-17 18:02 ` Aneesh Kumar K.V [this message]
2011-02-17 18:02 ` [PATCH 10/14] fs/9p: Add . and .. dentry revalidation flag Aneesh Kumar K.V
2011-02-17 18:02 ` [PATCH 11/14] fs/9p: Mark directory inode invalid for many directory inode operations Aneesh Kumar K.V
2011-02-17 18:02 ` [PATCH 12/14] fs/9p: mark inode attribute invalid on rename and unlink Aneesh Kumar K.V
2011-02-17 18:02 ` [PATCH 13/14] fs/9p: Workaround vfs rename rehash bug Aneesh Kumar K.V
2011-02-17 18:02 ` [PATCH 14/14] fs/9p: Prevent multiple inclusion of same header Aneesh Kumar K.V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297965725-25603-10-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).