* [PATCH] [net/9p] Change wake_up to wake_up_all() in the virtio transport.
@ 2011-03-08 23:39 Venkateswararao Jujjuri (JV)
2011-03-09 9:17 ` Aneesh Kumar K. V
0 siblings, 1 reply; 2+ messages in thread
From: Venkateswararao Jujjuri (JV) @ 2011-03-08 23:39 UTC (permalink / raw)
To: v9fs-developer; +Cc: linux-fsdevel, Venkateswararao Jujjuri (JV)
This fix wakes up all the threads waiting for the space on VirtIO ring.
Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
---
net/9p/trans_virtio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
index 9b550ed..e90e954 100644
--- a/net/9p/trans_virtio.c
+++ b/net/9p/trans_virtio.c
@@ -148,7 +148,7 @@ static void req_done(struct virtqueue *vq)
if (rc != NULL) {
if (!chan->ring_bufs_avail) {
chan->ring_bufs_avail = 1;
- wake_up(chan->vc_wq);
+ wake_up_all(chan->vc_wq);
}
spin_unlock_irqrestore(&chan->lock, flags);
P9_DPRINTK(P9_DEBUG_TRANS, ": rc %p\n", rc);
--
1.6.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [net/9p] Change wake_up to wake_up_all() in the virtio transport.
2011-03-08 23:39 [PATCH] [net/9p] Change wake_up to wake_up_all() in the virtio transport Venkateswararao Jujjuri (JV)
@ 2011-03-09 9:17 ` Aneesh Kumar K. V
0 siblings, 0 replies; 2+ messages in thread
From: Aneesh Kumar K. V @ 2011-03-09 9:17 UTC (permalink / raw)
To: Venkateswararao Jujjuri (JV), v9fs-developer
Cc: linux-fsdevel, Venkateswararao Jujjuri (JV)
On Tue, 8 Mar 2011 15:39:24 -0800, "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com> wrote:
> This fix wakes up all the threads waiting for the space on VirtIO
> ring.
It would be nice to document in commit message what error you
saw without the change. Is it that the tasks were waiting even though
there was space in the virtio ring because they didn't get woken up ?
>
> Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
> ---
> net/9p/trans_virtio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
> index 9b550ed..e90e954 100644
> --- a/net/9p/trans_virtio.c
> +++ b/net/9p/trans_virtio.c
> @@ -148,7 +148,7 @@ static void req_done(struct virtqueue *vq)
> if (rc != NULL) {
> if (!chan->ring_bufs_avail) {
> chan->ring_bufs_avail = 1;
> - wake_up(chan->vc_wq);
> + wake_up_all(chan->vc_wq);
> }
> spin_unlock_irqrestore(&chan->lock, flags);
> P9_DPRINTK(P9_DEBUG_TRANS, ": rc %p\n", rc);
> --
-aneesh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-09 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-08 23:39 [PATCH] [net/9p] Change wake_up to wake_up_all() in the virtio transport Venkateswararao Jujjuri (JV)
2011-03-09 9:17 ` Aneesh Kumar K. V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).