* [PATCH] fs/9p: Use updated offset for writing
@ 2011-03-16 5:09 M. Mohan Kumar
2011-03-16 8:05 ` Aneesh Kumar K. V
0 siblings, 1 reply; 3+ messages in thread
From: M. Mohan Kumar @ 2011-03-16 5:09 UTC (permalink / raw)
To: v9fs-developer; +Cc: linux-fsdevel, linux-kernel
Use the updated offset given by generic_write_checks. Without this fix,
even if a file is opened in O_APPEND mode, data will be written at current
file position instead of end of file.
Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
---
fs/9p/vfs_file.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index 6997eb6..51049cd 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -510,7 +510,7 @@ v9fs_file_write(struct file *filp, const char __user * data,
return v9fs_file_write_internal(filp->f_path.dentry->d_inode,
filp->private_data,
- data, count, offset, 1);
+ data, count, &origin, 1);
out:
return retval;
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/9p: Use updated offset for writing
2011-03-16 5:09 [PATCH] fs/9p: Use updated offset for writing M. Mohan Kumar
@ 2011-03-16 8:05 ` Aneesh Kumar K. V
2011-03-16 11:18 ` M. Mohan Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Aneesh Kumar K. V @ 2011-03-16 8:05 UTC (permalink / raw)
To: M. Mohan Kumar, v9fs-developer; +Cc: linux-fsdevel, linux-kernel
On Wed, 16 Mar 2011 10:39:16 +0530, "M. Mohan Kumar" <mohan@in.ibm.com> wrote:
> Use the updated offset given by generic_write_checks. Without this fix,
> even if a file is opened in O_APPEND mode, data will be written at current
> file position instead of end of file.
>
> Signed-off-by: M. Mohan Kumar <mohan@in.ibm.com>
> ---
> fs/9p/vfs_file.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index 6997eb6..51049cd 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -510,7 +510,7 @@ v9fs_file_write(struct file *filp, const char __user * data,
>
> return v9fs_file_write_internal(filp->f_path.dentry->d_inode,
> filp->private_data,
> - data, count, offset, 1);
> + data, count, &origin, 1);
> out:
> return retval;
> }
You should also update offset on success.
-aneesh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/9p: Use updated offset for writing
2011-03-16 8:05 ` Aneesh Kumar K. V
@ 2011-03-16 11:18 ` M. Mohan Kumar
0 siblings, 0 replies; 3+ messages in thread
From: M. Mohan Kumar @ 2011-03-16 11:18 UTC (permalink / raw)
To: Aneesh Kumar K. V; +Cc: v9fs-developer, linux-fsdevel, linux-kernel
On Wednesday 16 March 2011 1:35:46 pm Aneesh Kumar K. V wrote:
> On Wed, 16 Mar 2011 10:39:16 +0530, "M. Mohan Kumar" <mohan@in.ibm.com>
wrote:
> > Use the updated offset given by generic_write_checks. Without this fix,
> > even if a file is opened in O_APPEND mode, data will be written at
> > current file position instead of end of file.
>
> You should also update offset on success.
Thanks Aneesh, I will send a updated patch.
----
M. Mohan Kumar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-16 11:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-16 5:09 [PATCH] fs/9p: Use updated offset for writing M. Mohan Kumar
2011-03-16 8:05 ` Aneesh Kumar K. V
2011-03-16 11:18 ` M. Mohan Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).