From: Ryan Mallon <ryan@bluewatersys.com>
To: viro@zeniv.linux.org.uk, dchinner@redhat.com, Trond.Myklebust@netapp.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfs@vger.kernel.org, Ryan Mallon <ryan@bluewatersys.com>
Subject: [RFC PATCH 2/2] Use __igrab instead of igrab in nfs_inode_add_request
Date: Mon, 28 Mar 2011 14:56:01 +1300 [thread overview]
Message-ID: <1301277361-9453-3-git-send-email-ryan@bluewatersys.com> (raw)
In-Reply-To: <1301277361-9453-1-git-send-email-ryan@bluewatersys.com>
nfs_inode_add_request already holds inode->i_lock, so call the unlocked
__igrab instead of igrab.
Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
---
fs/nfs/write.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 85d7525..b161642 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -390,7 +390,7 @@ static int nfs_inode_add_request(struct inode *inode, struct nfs_page *req)
error = radix_tree_insert(&nfsi->nfs_page_tree, req->wb_index, req);
BUG_ON(error);
if (!nfsi->npages) {
- igrab(inode);
+ __igrab(inode);
if (nfs_have_delegation(inode, FMODE_WRITE))
nfsi->change_attr++;
}
--
1.7.0.4
next prev parent reply other threads:[~2011-03-28 1:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 1:55 [RFC PATCH 0/2] Introduce unlocked version of igrab Ryan Mallon
2011-03-28 1:56 ` [RFC PATCH 1/2] Add " Ryan Mallon
[not found] ` <1301277361-9453-2-git-send-email-ryan-7Wk5F4Od5/oYd5yxfr4S2w@public.gmane.org>
2011-03-28 2:54 ` Matthew Wilcox
[not found] ` <20110328025423.GN13806-6jwH94ZQLHl74goWV3ctuw@public.gmane.org>
2011-03-28 4:39 ` Ryan Mallon
[not found] ` <4D9010F1.1040909-7Wk5F4Od5/oYd5yxfr4S2w@public.gmane.org>
2011-03-28 5:19 ` [PATCH] fs: don't use igrab() while holding i_lock (was Re: [RFC PATCH 1/2] Add unlocked version of igrab.) Dave Chinner
2011-03-28 1:56 ` Ryan Mallon [this message]
[not found] ` <1301277361-9453-1-git-send-email-ryan-7Wk5F4Od5/oYd5yxfr4S2w@public.gmane.org>
2011-03-28 4:43 ` [RFC PATCH 0/2] Introduce unlocked version of igrab Dave Chinner
2011-03-28 4:47 ` Ryan Mallon
2011-03-28 5:03 ` Ryan Mallon
[not found] ` <4D9016B7.1080505-7Wk5F4Od5/oYd5yxfr4S2w@public.gmane.org>
2011-03-28 6:01 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301277361-9453-3-git-send-email-ryan@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=Trond.Myklebust@netapp.com \
--cc=dchinner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).