* [PATCH] net/9p: nwname should be an unsigned int
@ 2011-03-30 20:18 Harsh Prateek Bora
2011-03-31 0:51 ` Venkateswararao Jujjuri
0 siblings, 1 reply; 2+ messages in thread
From: Harsh Prateek Bora @ 2011-03-30 20:18 UTC (permalink / raw)
To: linux-fsdevel; +Cc: ericvh, jvrao, Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
---
include/net/9p/client.h | 2 +-
net/9p/client.c | 6 +++---
net/9p/protocol.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/net/9p/client.h b/include/net/9p/client.h
index 0a30977..31e5343 100644
--- a/include/net/9p/client.h
+++ b/include/net/9p/client.h
@@ -218,7 +218,7 @@ void p9_client_disconnect(struct p9_client *clnt);
void p9_client_begin_disconnect(struct p9_client *clnt);
struct p9_fid *p9_client_attach(struct p9_client *clnt, struct p9_fid *afid,
char *uname, u32 n_uname, char *aname);
-struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
+struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, char **wnames,
int clone);
int p9_client_open(struct p9_fid *fid, int mode);
int p9_client_fcreate(struct p9_fid *fid, char *name, u32 perm, int mode,
diff --git a/net/9p/client.c b/net/9p/client.c
index 2ccbf04..1af4afb 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -929,7 +929,7 @@ error:
}
EXPORT_SYMBOL(p9_client_attach);
-struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
+struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, char **wnames,
int clone)
{
int err;
@@ -937,7 +937,7 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
struct p9_fid *fid;
struct p9_qid *wqids;
struct p9_req_t *req;
- int16_t nwqids, count;
+ uint16_t nwqids, count;
err = 0;
wqids = NULL;
@@ -955,7 +955,7 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
fid = oldfid;
- P9_DPRINTK(P9_DEBUG_9P, ">>> TWALK fids %d,%d nwname %d wname[0] %s\n",
+ P9_DPRINTK(P9_DEBUG_9P, ">>> TWALK fids %d,%d nwname %ud wname[0] %s\n",
oldfid->fid, fid->fid, nwname, wnames ? wnames[0] : NULL);
req = p9_client_rpc(clnt, P9_TWALK, "ddT", oldfid->fid, fid->fid,
diff --git a/net/9p/protocol.c b/net/9p/protocol.c
index 8a4084f..0573b9b 100644
--- a/net/9p/protocol.c
+++ b/net/9p/protocol.c
@@ -265,7 +265,7 @@ p9pdu_vreadf(struct p9_fcall *pdu, int proto_version, const char *fmt,
}
break;
case 'T':{
- int16_t *nwname = va_arg(ap, int16_t *);
+ uint16_t *nwname = va_arg(ap, uint16_t *);
char ***wnames = va_arg(ap, char ***);
errcode = p9pdu_readf(pdu, proto_version,
@@ -495,7 +495,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt,
}
break;
case 'T':{
- int16_t nwname = va_arg(ap, int);
+ uint16_t nwname = va_arg(ap, int);
const char **wnames = va_arg(ap, const char **);
errcode = p9pdu_writef(pdu, proto_version, "w",
--
1.7.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/9p: nwname should be an unsigned int
2011-03-30 20:18 [PATCH] net/9p: nwname should be an unsigned int Harsh Prateek Bora
@ 2011-03-31 0:51 ` Venkateswararao Jujjuri
0 siblings, 0 replies; 2+ messages in thread
From: Venkateswararao Jujjuri @ 2011-03-31 0:51 UTC (permalink / raw)
To: Harsh Prateek Bora; +Cc: linux-fsdevel, ericvh
On 03/30/2011 01:18 PM, Harsh Prateek Bora wrote:
> Signed-off-by: Harsh Prateek Bora<harsh@linux.vnet.ibm.com>
Reviewed-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
> ---
> include/net/9p/client.h | 2 +-
> net/9p/client.c | 6 +++---
> net/9p/protocol.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/net/9p/client.h b/include/net/9p/client.h
> index 0a30977..31e5343 100644
> --- a/include/net/9p/client.h
> +++ b/include/net/9p/client.h
> @@ -218,7 +218,7 @@ void p9_client_disconnect(struct p9_client *clnt);
> void p9_client_begin_disconnect(struct p9_client *clnt);
> struct p9_fid *p9_client_attach(struct p9_client *clnt, struct p9_fid *afid,
> char *uname, u32 n_uname, char *aname);
> -struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
> +struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, char **wnames,
> int clone);
> int p9_client_open(struct p9_fid *fid, int mode);
> int p9_client_fcreate(struct p9_fid *fid, char *name, u32 perm, int mode,
> diff --git a/net/9p/client.c b/net/9p/client.c
> index 2ccbf04..1af4afb 100644
> --- a/net/9p/client.c
> +++ b/net/9p/client.c
> @@ -929,7 +929,7 @@ error:
> }
> EXPORT_SYMBOL(p9_client_attach);
>
> -struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
> +struct p9_fid *p9_client_walk(struct p9_fid *oldfid, uint16_t nwname, char **wnames,
> int clone)
> {
> int err;
> @@ -937,7 +937,7 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
> struct p9_fid *fid;
> struct p9_qid *wqids;
> struct p9_req_t *req;
> - int16_t nwqids, count;
> + uint16_t nwqids, count;
>
> err = 0;
> wqids = NULL;
> @@ -955,7 +955,7 @@ struct p9_fid *p9_client_walk(struct p9_fid *oldfid, int nwname, char **wnames,
> fid = oldfid;
>
>
> - P9_DPRINTK(P9_DEBUG_9P, ">>> TWALK fids %d,%d nwname %d wname[0] %s\n",
> + P9_DPRINTK(P9_DEBUG_9P, ">>> TWALK fids %d,%d nwname %ud wname[0] %s\n",
> oldfid->fid, fid->fid, nwname, wnames ? wnames[0] : NULL);
>
> req = p9_client_rpc(clnt, P9_TWALK, "ddT", oldfid->fid, fid->fid,
> diff --git a/net/9p/protocol.c b/net/9p/protocol.c
> index 8a4084f..0573b9b 100644
> --- a/net/9p/protocol.c
> +++ b/net/9p/protocol.c
> @@ -265,7 +265,7 @@ p9pdu_vreadf(struct p9_fcall *pdu, int proto_version, const char *fmt,
> }
> break;
> case 'T':{
> - int16_t *nwname = va_arg(ap, int16_t *);
> + uint16_t *nwname = va_arg(ap, uint16_t *);
> char ***wnames = va_arg(ap, char ***);
>
> errcode = p9pdu_readf(pdu, proto_version,
> @@ -495,7 +495,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt,
> }
> break;
> case 'T':{
> - int16_t nwname = va_arg(ap, int);
> + uint16_t nwname = va_arg(ap, int);
> const char **wnames = va_arg(ap, const char **);
>
> errcode = p9pdu_writef(pdu, proto_version, "w",
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-31 0:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-30 20:18 [PATCH] net/9p: nwname should be an unsigned int Harsh Prateek Bora
2011-03-31 0:51 ` Venkateswararao Jujjuri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).