From: "Dr. Bernd Feige" <bernd.feige@uniklinik-freiburg.de>
To: Bongani Hlope <bonganih@bankservafrica.com>
Cc: torvalds@linux-foundation.org, arnd@arndb.de, npiggin@kernel.dk,
greg@kroah.com, hch@lst.de, bonganilinux@mweb.co.za, rjw@sisk.pl,
petr@vandrovec.name, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Regression] 2.6.38 ncpfs
Date: Fri, 15 Apr 2011 10:53:50 +0200 [thread overview]
Message-ID: <1302857630.2798.0.camel@pst15.ukl.uni-freiburg.de> (raw)
In-Reply-To: <4DA815B6020000AC0004595E@CLU_MAIL.BANKSERV.CO.ZA>
Hi Bongani, Linus et al.
> > You might also try to replace it with
> >
> > BUG_ON(!mutex_is_locked(&dentry->d_parent->d_inode->i_mutex))
> >
> > ie add that "d_parent" there. Just for testing - I think the real fix
> > really is to remove it, but I'd personally be happier knowing that
> > _if_ it were to have that d_parent there, it would have worked.
>
> I've made that change and ncpfs works fine with it. I've attached a
> patch that changes the BUG_ON to look at the parent.
Seconded, checked it with the Novell servers in our clinic and it works
like a charm - even with the large directories for which I still have to
revert commit 3825bdb7ed920845961f32f364454bee5f469abb from 2.6.37.6
(https://lkml.org/lkml/2011/1/26/302). Thanks a lot!
Bernd
next prev parent reply other threads:[~2011-04-15 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 7:53 [Regression] 2.6.38 ncpfs Bongani Hlope
2011-04-15 8:53 ` Dr. Bernd Feige [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-05 16:58 Bongani Hlope
2011-04-14 17:14 ` Bongani Hlope
2011-04-14 17:29 ` Linus Torvalds
2011-04-14 20:17 ` Bongani Hlope
2011-04-14 20:22 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302857630.2798.0.camel@pst15.ukl.uni-freiburg.de \
--to=bernd.feige@uniklinik-freiburg.de \
--cc=arnd@arndb.de \
--cc=bonganih@bankservafrica.com \
--cc=bonganilinux@mweb.co.za \
--cc=greg@kroah.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=petr@vandrovec.name \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).