From: Chris Mason <chris.mason@oracle.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>, xfs <xfs@oss.sgi.com>,
jack <jack@suse.cz>, axboe <axboe@kernel.dk>,
dchinner <dchinner@redhat.com>
Subject: Re: buffered writeback torture program
Date: Thu, 21 Apr 2011 14:47:22 -0400 [thread overview]
Message-ID: <1303411432-sup-9992@think> (raw)
In-Reply-To: <004198D6-9941-4322-BDB1-8176B80262C7@dilger.ca>
Excerpts from Andreas Dilger's message of 2011-04-21 14:43:47 -0400:
> On 2011-04-21, at 12:29 PM, Chris Mason wrote:
> > Excerpts from Christoph Hellwig's message of 2011-04-21 14:08:05 -0400:
> >> On Thu, Apr 21, 2011 at 02:02:43PM -0400, Chris Mason wrote:
> >>> For this program, they are almost all dirty pages.
> >>>
> >>> I tried patching it to give up if we seek but it is still pretty slow.
> >>> There's something else going on in addition to the xfs clustering being
> >>> too aggressive.
> >>
> >> I'm not sure where you this beeing to agressive from - it's doing
> >> exactly the same amount of I/O as a filesystem writing out a single
> >> page from ->writepage or using write_cache_pages (either directly
> >> or as a copy) as ->writepages. The only thing special compared to
> >> the no ->writepages case is that it's submitting a large I/O
> >> from the first ->writepage call.
> >
> > Ok, I see what you mean. The clustering code stops once it hits
> > nr_to_write, I missed that. So we shouldn't be doing more than a single
> > writepages call.
>
> I wonder if it makes sense to disentangle the two processes state in the kernel, by forking the fsync thread before any writes are done. That would avoid penalizing the random writer in the VM/VFS, but means there needs to be some coordination between the threads (e.g. polling for a sentinel file written when the sequential phase is complete).
>
The test itself may not be realistic, but I actually think its a feature
that we end up stuck doing the random buffered ios. Somehow it is much
slower than it should be on my box on xfs. This isn't universal, other
machines seem to be working fine.
-chris
next prev parent reply other threads:[~2011-04-21 18:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 18:23 buffered writeback torture program Chris Mason
2011-04-20 22:06 ` Vivek Goyal
2011-04-21 11:09 ` Chris Mason
2011-04-21 15:25 ` Chris Mason
2011-04-21 15:35 ` Vivek Goyal
2011-04-21 16:55 ` Jan Kara
2011-04-21 16:57 ` Chris Mason
2011-04-21 20:44 ` Jan Kara
2011-04-21 8:32 ` Christoph Hellwig
2011-04-21 17:34 ` Chris Mason
2011-04-21 17:41 ` Christoph Hellwig
2011-04-21 17:59 ` Andreas Dilger
2011-04-21 18:02 ` Christoph Hellwig
2011-04-21 18:02 ` Chris Mason
2011-04-21 18:08 ` Christoph Hellwig
2011-04-21 18:29 ` Chris Mason
2011-04-21 18:43 ` Andreas Dilger
2011-04-21 18:47 ` Chris Mason [this message]
2011-04-21 18:00 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303411432-sup-9992@think \
--to=chris.mason@oracle.com \
--cc=adilger@dilger.ca \
--cc=axboe@kernel.dk \
--cc=dchinner@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).