From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sage Weil Subject: [PATCH 09/18] xfs: remove unnecessary dentry_unhash from rmdir/rename_dir Date: Mon, 9 May 2011 21:43:27 -0700 Message-ID: <1305002616-16782-10-git-send-email-sage@newdream.net> References: <1305002616-16782-1-git-send-email-sage@newdream.net> Cc: Sage Weil To: viro@ZenIV.linux.org.uk, hch@lst.de, linux-fsdevel@vger.kernel.org Return-path: Received: from cobra.newdream.net ([66.33.216.30]:57295 "EHLO cobra.newdream.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966Ab1EJFKp (ORCPT ); Tue, 10 May 2011 01:10:45 -0400 In-Reply-To: <1305002616-16782-1-git-send-email-sage@newdream.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: XFS has no problems with references to unlinked directories. Signed-off-by: Sage Weil --- fs/xfs/linux-2.6/xfs_iops.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c index f791485..dd21784 100644 --- a/fs/xfs/linux-2.6/xfs_iops.c +++ b/fs/xfs/linux-2.6/xfs_iops.c @@ -330,9 +330,6 @@ xfs_vn_unlink( struct xfs_name name; int error; - if (S_ISDIR(dentry->d_inode->i_mode)) - dentry_unhash(dentry); - xfs_dentry_to_name(&name, dentry); error = -xfs_remove(XFS_I(dir), &name, XFS_I(dentry->d_inode)); @@ -395,9 +392,6 @@ xfs_vn_rename( struct xfs_name oname; struct xfs_name nname; - if (ndentry->d_inode && S_ISDIR(ndentry->d_inode->i_mode)) - dentry_unhash(ndentry); - xfs_dentry_to_name(&oname, odentry); xfs_dentry_to_name(&nname, ndentry); -- 1.7.1