From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sage Weil Subject: [PATCH 17/18] gfs2: remove unnecessary dentry_unhash on rmdir/rename_dir Date: Mon, 9 May 2011 21:43:35 -0700 Message-ID: <1305002616-16782-18-git-send-email-sage@newdream.net> References: <1305002616-16782-1-git-send-email-sage@newdream.net> Cc: Sage Weil , Steven Whitehouse , cluster-devel@redhat.com To: viro@ZenIV.linux.org.uk, hch@lst.de, linux-fsdevel@vger.kernel.org Return-path: Received: from cobra.newdream.net ([66.33.216.30]:57342 "EHLO cobra.newdream.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753910Ab1EJFLD (ORCPT ); Tue, 10 May 2011 01:11:03 -0400 In-Reply-To: <1305002616-16782-1-git-send-email-sage@newdream.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Gfs2 has no issues with lingering references to unlinked directory inodes. CC: Steven Whitehouse CC: cluster-devel@redhat.com Signed-off-by: Sage Weil --- fs/gfs2/ops_inode.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c index 4bf862c..09e436a 100644 --- a/fs/gfs2/ops_inode.c +++ b/fs/gfs2/ops_inode.c @@ -572,8 +572,6 @@ static int gfs2_rmdir(struct inode *dir, struct dentry *dentry) struct gfs2_holder ri_gh; int error; - dentry_unhash(dentry); - error = gfs2_rindex_hold(sdp, &ri_gh); if (error) return error; @@ -743,9 +741,6 @@ static int gfs2_rename(struct inode *odir, struct dentry *odentry, int error; if (ndentry->d_inode) { - if (S_ISDIR(ndentry->d_inode->i_mode)) - dentry_unhash(ndentry); - nip = GFS2_I(ndentry->d_inode); if (ip == nip) return 0; -- 1.7.1