From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Subject: Re: [PATCH v5 01/21] integrity: move ima inode integrity data management Date: Thu, 19 May 2011 18:45:21 -0400 Message-ID: <1305845121.2528.0.camel@localhost.localdomain> References: <1305557115-15652-1-git-send-email-zohar@linux.vnet.ibm.com> <1305557115-15652-2-git-send-email-zohar@linux.vnet.ibm.com> <20110519020619.GA10188@mail.hallyn.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, James Morris , David Safford , Andrew Morton , Greg KH , Dmitry Kasatkin , Mimi Zohar To: "Serge E. Hallyn" Return-path: In-Reply-To: <20110519020619.GA10188@mail.hallyn.com> Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 2011-05-18 at 21:06 -0500, Serge E. Hallyn wrote: > Quoting Mimi Zohar (zohar@linux.vnet.ibm.com): > > Move the inode integrity data(iint) management up to the integrity directory > > in order to share the iint among the different integrity models. > > You also > > rename several globally visible ima_* functions, structs, locks etc to > integrity_\0 > replace '20' by SHA1_DIGEST_SIZE > remove unnecessary initialization of iint_initialized to 0 Yes, will update the changelog to reflect these changes as well. > Which all are fine, but probably should be mentioned in changelog, > along with the magic phrase "no other functional changes" to aid > reviewers. Wasn't aware of this. > > Changelog: > > - Rebased on current ima_iint.c > > - Define integrity_iint_store/lock as static > > > > Signed-off-by: Mimi Zohar > > Acked-by: Serge Hallyn > > thanks, > -serge Thanks! Mimi