From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sage Weil Subject: [PATCH 14/26] hostfs: remove unnecessary dentry_unhash on rmdir, dir rename Date: Fri, 27 May 2011 13:42:07 -0700 Message-ID: <1306528939-30636-15-git-send-email-sage@newdream.net> References: <1306528939-30636-1-git-send-email-sage@newdream.net> Cc: linux-fsdevel@vger.kernel.org, Sage Weil , Jeff Dike , Richard Weinberger , user-mode-linux-devel@lists.sourceforge.net To: hch@infradead.org, viro@ZenIV.linux.org.uk Return-path: Received: from cobra.newdream.net ([66.33.216.30]:43507 "EHLO cobra.newdream.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756741Ab1E0Ulw (ORCPT ); Fri, 27 May 2011 16:41:52 -0400 In-Reply-To: <1306528939-30636-1-git-send-email-sage@newdream.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: hostfs does not have problems with references to unlinked directories. CC: Jeff Dike CC: Richard Weinberger CC: user-mode-linux-devel@lists.sourceforge.net Signed-off-by: Sage Weil --- fs/hostfs/hostfs_kern.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index e6816b9..2638c83 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_kern.c @@ -683,8 +683,6 @@ int hostfs_rmdir(struct inode *ino, struct dentry *dentry) char *file; int err; - dentry_unhash(dentry); - if ((file = dentry_name(dentry)) == NULL) return -ENOMEM; err = do_rmdir(file); @@ -738,9 +736,6 @@ int hostfs_rename(struct inode *from_ino, struct dentry *from, char *from_name, *to_name; int err; - if (to->d_inode && S_ISDIR(to->d_inode->i_mode)) - dentry_unhash(to); - if ((from_name = dentry_name(from)) == NULL) return -ENOMEM; if ((to_name = dentry_name(to)) == NULL) { -- 1.7.0