From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sage Weil Subject: [PATCH 21/26] coda: remove unnecessary dentry_unhash on rmdir, dir rename Date: Fri, 27 May 2011 13:42:14 -0700 Message-ID: <1306528939-30636-22-git-send-email-sage@newdream.net> References: <1306528939-30636-1-git-send-email-sage@newdream.net> Cc: linux-fsdevel@vger.kernel.org, Sage Weil , Jan Harkes , coda@cs.cmu.edu, codalist@coda.cs.cmu.edu To: hch@infradead.org, viro@ZenIV.linux.org.uk Return-path: Received: from cobra.newdream.net ([66.33.216.30]:43547 "EHLO cobra.newdream.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756806Ab1E0Ulx (ORCPT ); Fri, 27 May 2011 16:41:53 -0400 In-Reply-To: <1306528939-30636-1-git-send-email-sage@newdream.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Coda has no problems with references to unlinked directories. CC: Jan Harkes CC: coda@cs.cmu.edu CC: codalist@coda.cs.cmu.edu Signed-off-by: Sage Weil --- fs/coda/dir.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/fs/coda/dir.c b/fs/coda/dir.c index a46126f..2b8dae4 100644 --- a/fs/coda/dir.c +++ b/fs/coda/dir.c @@ -336,8 +336,6 @@ static int coda_rmdir(struct inode *dir, struct dentry *de) int len = de->d_name.len; int error; - dentry_unhash(de); - error = venus_rmdir(dir->i_sb, coda_i2f(dir), name, len); if (!error) { /* VFS may delete the child */ @@ -361,9 +359,6 @@ static int coda_rename(struct inode *old_dir, struct dentry *old_dentry, int new_length = new_dentry->d_name.len; int error; - if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode)) - dentry_unhash(new_dentry); - error = venus_rename(old_dir->i_sb, coda_i2f(old_dir), coda_i2f(new_dir), old_length, new_length, (const char *) old_name, (const char *)new_name); -- 1.7.0